Skip to content

rustfmt removes module-level attributes when there are comments #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wilfred opened this issue Jan 18, 2017 · 5 comments
Closed

rustfmt removes module-level attributes when there are comments #1280

Wilfred opened this issue Jan 18, 2017 · 5 comments

Comments

@Wilfred
Copy link

Wilfred commented Jan 18, 2017

Given the Rust code:

#![allow(dead_code)] // bar

rustfmt 0.7 produces:

 // bar
@Wilfred
Copy link
Author

Wilfred commented Jan 18, 2017

Duplicate of #1277.

@Wilfred Wilfred closed this as completed Jan 18, 2017
@mulkieran
Copy link

@Wilfred Could you reopen? This might be related to #1284, but #1277 was actually a different issue.

@Wilfred Wilfred reopened this Jan 25, 2017
@nrc nrc closed this as completed in 2261947 Jan 26, 2017
@ppannuto ppannuto mentioned this issue Jan 31, 2017
Merged
@Wilfred
Copy link
Author

Wilfred commented Feb 18, 2017

@nrc would you be able to tag a new release? We'd love to integrate rustfmt into the CI for the Remacs project, but we're seeing this issue.

@nrc
Copy link
Member

nrc commented Mar 7, 2017

@Wilfred I just released v0.8 (it took a while because I did some large refactoring and wanted to give it a little time for testing).

mulkieran added a commit to mulkieran/stratisd that referenced this issue Mar 7, 2017
@mulkieran
No longer pin to lower rustfmt version
eebe139 
The bug that we were triggering was fixed in the newest version.

rust-lang/rustfmt#1280

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran mentioned this issue Mar 7, 2017
Closed
@Wilfred
Copy link
Author

Wilfred commented Mar 7, 2017

Thanks :)

mulkieran added a commit to mulkieran/stratisd that referenced this issue Mar 27, 2017
@mulkieran
No longer pin to lower rustfmt version
abe1b51 
The bug that we were triggering was fixed in the newest version.

rust-lang/rustfmt#1280

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran mentioned this issue Mar 27, 2017
Closed
mulkieran added a commit to mulkieran/stratisd that referenced this issue May 5, 2017
@mulkieran
No longer pin to lower rustfmt version
c29d4f6 
The bug that we were triggering was fixed in the newest version.

rust-lang/rustfmt#1280

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran mentioned this issue May 5, 2017
Merged
mulkieran added a commit to mulkieran/stratisd that referenced this issue May 5, 2017
@mulkieran
No longer pin to lower rustfmt version
90945ae 
The bug that we were triggering was fixed in the newest version.

rust-lang/rustfmt#1280

Signed-off-by: mulhern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wilfred @nrc @mulkieran