Skip to content

Perf summaries completely ignore rustdoc #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jyn514 opened this issue Aug 22, 2021 · 3 comments · Fixed by #1011
Closed

Perf summaries completely ignore rustdoc #980

jyn514 opened this issue Aug 22, 2021 · 3 comments · Fixed by #1011

Comments

@jyn514
Copy link
Member

jyn514 commented Aug 22, 2021

This perf run had over 100% regressions for rustdoc, but rust-timer said there were no significant changes.

Originally posted by @rust-timer in rust-lang/rust#88219 (comment)

@jyn514
Copy link
Member Author

jyn514 commented Sep 17, 2021

Relevant code seems to be

fn comparison_is_relevant(confidence: ComparisonConfidence, is_master_commit: bool) -> bool {
/
pub fn confidence(&self) -> ComparisonConfidence {
.

@rylev do you know when you'll get a chance to look into this? Posting "no relevant changes" when there's a regression is worse than not posting anything at all IMO.

@jyn514
Copy link
Member Author

jyn514 commented Sep 17, 2021

Or alternatively, how can I run that code locally so I can debug it? cargo run --bin site seems to run the site, not the bot.

@jyn514
Copy link
Member Author

jyn514 commented Sep 17, 2021

Ugh, they're being deliberately filtered out for some reason.

fn get_individual_comparisons(&self) -> impl Iterator<Item = &TestResultComparison> {
self.statistics.iter().filter(|b| b.profile != Profile::Doc)
}

We discussed removing this in https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/triage.202021.2009.2007/near/252361701 so I'm going to go ahead and make a PR that doesn't filter them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant