-
Notifications
You must be signed in to change notification settings - Fork 152
Perf summaries completely ignore rustdoc #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Relevant code seems to be Line 704 in 5c8e64a
rustc-perf/site/src/comparison.rs Line 270 in 5c8e64a
@rylev do you know when you'll get a chance to look into this? Posting "no relevant changes" when there's a regression is worse than not posting anything at all IMO. |
Or alternatively, how can I run that code locally so I can debug it? |
Ugh, they're being deliberately filtered out for some reason. rustc-perf/site/src/comparison.rs Lines 571 to 573 in 5c8e64a
We discussed removing this in https://rust-lang.zulipchat.com/#narrow/stream/247081-t-compiler.2Fperformance/topic/triage.202021.2009.2007/near/252361701 so I'm going to go ahead and make a PR that doesn't filter them out. |
This perf run had over 100% regressions for rustdoc, but rust-timer said there were no significant changes.
Originally posted by @rust-timer in rust-lang/rust#88219 (comment)
The text was updated successfully, but these errors were encountered: