Merge pull request #1688 from Kobzol/fix-compare-page-url-reset

Kobzol · web-flow · commit 9a87eb44d716 · 2023-08-06T12:31:32.000+02:00
Correctly remove query parameters in compare page
diff --git a/site/frontend/src/utils/navigation.ts b/site/frontend/src/utils/navigation.ts
@@ -10,6 +10,8 @@ export function createUrlWithAppendedParams(params: Dict<any>): URL {
       const stringified = value.toString();
       if (stringified !== "") {
         url.searchParams.set(key, stringified);
+      } else {
+        url.searchParams.delete(key);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@ export function createUrlWithAppendedParams(params: Dict<any>): URL {`
`10`	`10`	`const stringified = value.toString();`
`11`	`11`	`if (stringified !== "") {`
`12`	`12`	`url.searchParams.set(key, stringified);`
	`13`	`+ } else {`
	`14`	`+ url.searchParams.delete(key);`
`13`	`15`	`}`
`14`	`16`	`}`
`15`	`17`	`}`