Skip to content

Commit 5d05034

Browse files
Add triage for this week
1 parent 42fd135 commit 5d05034

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

triage/2020-12-08.md

+40
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# 2020-12-08 Triage Log
2+
3+
Quiet week.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [c7cff213e937c1bb301be807ce04fcf6092b9163..4fd4a98d4788bc987d7f7add9df5f5ead6a1c15e](https://perf.rust-lang.org/?start=c7cff213e937c1bb301be807ce04fcf6092b9163&end=4fd4a98d4788bc987d7f7add9df5f5ead6a1c15e&absolute=false&stat=instructions%3Au)
7+
8+
1 Regressions, 3 Improvements, 1 Mixed
9+
0 of them in rollups
10+
11+
#### Regressions
12+
13+
#### Improvements
14+
15+
[#79594](https://github.com/rust-lang/rust/issues/79594)
16+
- Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=c7cff213e937c1bb301be807ce04fcf6092b9163&end=d015f0d92144f0e72735a918aee8510b0fe2cff5&stat=instructions:u) (up to -1.7% on `incr-full` builds of `ctfe-stress-4-debug`)
17+
- Likely due to the stress test not reflecting benefits of memoizing CTFE, which
18+
this partially removed (due to the addition of heap allocation, which should
19+
not be deduplicated).
20+
21+
[#79680](https://github.com/rust-lang/rust/issues/79680)
22+
- Very large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=e6225434fff7d493baac0aa91c57f2da923ea196&end=2218520b8adf8b8e64b817537d9eb0a84840e2f1&stat=instructions:u) (up to -20.6% on `full` builds of `match-stress-enum-check`)
23+
- Fixes a regression from last week by adding a `#[inline]` attribute on some
24+
hot code. Improvements are likely not significant outside stress tests.
25+
26+
#### Mixed
27+
28+
[#78373](https://github.com/rust-lang/rust/issues/78373)
29+
- Very large improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=551a2c6cbcf239f662a18233cf647bf67e5a74ed&end=9122b769c8306b1cb3c8d1f96fca3ea3e208e22e&stat=instructions:u) (up to -28.4% on `incr-patched: println` builds of `clap-rs-debug`)
30+
- Large regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=551a2c6cbcf239f662a18233cf647bf67e5a74ed&end=9122b769c8306b1cb3c8d1f96fca3ea3e208e22e&stat=instructions:u) (up to 9.9% on `incr-patched: println` builds of `regression-31157-opt`)
31+
- Soundness fix ("Don't leak return value after panic in drop") and the perf
32+
results are mixed, largest ones mostly in incremental and generally likely
33+
just "generating more (necessary) LLVM IR".
34+
35+
#### Nags requiring follow up
36+
37+
- stdarch expansion causing a 40% libcore compile time regression is still not
38+
resolved, and resolution is unclear. It seems likely that this could be one of
39+
our key elements for improving std compile times at least, though.
40+
- No new nags.

0 commit comments

Comments
 (0)