Skip to content

Commit 0ed302e

Browse files
authored
Merge pull request #1518 from rust-lang/profile-comment
Add comment about unifying types to Profile
2 parents 2b9ebe1 + e49dcc1 commit 0ed302e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

collector/src/benchmark/profile.rs

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
/// Type of compilation used for benchmarking/profiling.
2+
// Note: This type is very similar to the definition of a profile in the database crate.
3+
// However, these types should not be unified, as they serve slightly different purposes.
4+
// This type is used for specifying profiles to be benchmarked using the CLI, which is not relevant
5+
// to the database crate.
6+
// In general, the database versions of types used in the collector should be considered a DB
7+
// implementation detail, as they may change when we alter database layout.
18
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, clap::ArgEnum, serde::Deserialize)]
29
#[clap(rename_all = "PascalCase")]
310
pub enum Profile {

0 commit comments

Comments
 (0)