Skip to content

Commit 6a824e9

Browse files
committed
compiletest: document {ignore,only}-{$target_triple,$target_arch} impl limitation
1 parent cdc10f0 commit 6a824e9

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

Diff for: src/tests/directives.md

+13
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,19 @@ means the test won't be compiled or run.
129129

130130
Some examples of `X` in `ignore-X` or `only-X`:
131131

132+
> NOTE:
133+
>
134+
> There's a current compiletest implementation limitation that an allow list is used
135+
> to help check for unknown directives (`src/tools/compiletest/src/directive-list.rs`).
136+
> The target triples and target archs for `//@ {ignore,only}-$target_triple` and
137+
> `//@ {ignore,only}-$target_arch` are computed based on all the builtin target specs,
138+
> such that they may be functional directives but are not listed in the known directives
139+
> allow list. In that case, you can `//@ {ignore,only}-{$target_triple,$target_arch}` to
140+
> the directives allow list.
141+
>
142+
> We would like to rework directive handling to make this allow list unnecessary in the
143+
> future.
144+
132145
- A full target triple: `aarch64-apple-ios`
133146
- Architecture: `aarch64`, `arm`, `mips`, `wasm32`, `x86_64`, `x86`,
134147
...

0 commit comments

Comments
 (0)