-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Description
This is a tracking issue for RFC 3191.
The feature gate for the issue is #![feature(debugger_visualizer)]
.
About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Steps
- Implement the RFCAdjust documentation (Add documentation for debugger_visualizer attribute reference#1335)Stabilization PR (Stabilize debugger_visualizer #108668)To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Unresolved Questions
No unresolved questions at this time.
Implementation history
Create new attribute
#[debugger_viusalizer]
and add support for embedding NatVis visualizers through this attribute: Add a new Rust attribute to support embedding debugger visualizers #91779Adding support for embedding pretty-printers via new attribute: Add support for embedding pretty printers via
#[debugger_visualizer]
attribute #97028To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Activity
ridwanabdillahi commentedon Apr 11, 2022
@rustbot claim
ridwanabdillahi commentedon May 27, 2022
#[debugger_visualizer]
attribute #97028madsmtm commentedon Aug 10, 2022
What's the plan for LLDB? It seems like the design of LLDB is slightly different, they err on the side of "the binary cannot be trusted", so automatically loading these kind of things is not really supported - but maybe it would be possible to provide when using
rust-lldb
?pravic commentedon Jan 12, 2023
Why
#![debugger_visualizer(natvis_file = "../Foo.natvis")]
in Rust code and not
in Cargo.toml?
29 remaining items
Rollup merge of rust-lang#108668 - gibbyfree:stabilizedebuggervisuali…
Rollup merge of rust-lang#108668 - gibbyfree:stabilizedebuggervisuali…
ehuss commentedon May 6, 2023
I'm concerned about the stabilization of this feature in its current state. I filed a few issues (see F-debugger_visualizer`#![feature(debugger_visualizer)]`
). It is almost unusable for the purpose of authoring visualizers since you can't modify a file without needing to delete your build directory and starting over. I would recommend looking at either fixing those issues or considering to revert the stabilization, since otherwise I think it would provide a poor first impression.
lcnr commentedon May 7, 2023
nominating for t-compiler meeting due to the above concern. if we're able to remove this asynchronously before then we can always remove the nomination.
michaelwoerister commentedon May 8, 2023
I agree that these issue are a blocking concern for the feature. If I'm reading the schedule right, we have until May 26 to either fix the issue or revert stabilization.
michaelwoerister commentedon May 11, 2023
Thanks for opening the issues, @ehuss! I've assigned myself to do an initial investigation.
apiraino commentedon May 18, 2023
Discussed in T-compiler meeting on Zulip
Linking #111641 that should address this.
@rustbot label -I-compiler-nominated
Mark-Simulacrum commentedon Jul 1, 2023
Closing this tracking issue -- I believe the feature is now stabilized, and the concerns raised were addressed.