Skip to content

Tracking Issue for debugger_visualizer #95939

@wesleywiser

Description

@wesleywiser
Member

This is a tracking issue for RFC 3191.
The feature gate for the issue is #![feature(debugger_visualizer)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

No unresolved questions at this time.

Implementation history

Activity

added
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
T-langRelevant to the language team
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Apr 11, 2022
ridwanabdillahi

ridwanabdillahi commented on Apr 11, 2022

@ridwanabdillahi
Contributor

@rustbot claim

ridwanabdillahi

ridwanabdillahi commented on May 27, 2022

@ridwanabdillahi
madsmtm

madsmtm commented on Aug 10, 2022

@madsmtm
Contributor

What's the plan for LLDB? It seems like the design of LLDB is slightly different, they err on the side of "the binary cannot be trusted", so automatically loading these kind of things is not really supported - but maybe it would be possible to provide when using rust-lldb?

pravic

pravic commented on Jan 12, 2023

@pravic
Contributor

Why

#![debugger_visualizer(natvis_file = "../Foo.natvis")] 

in Rust code and not

debug_visualizer = "foo.natvis"

in Cargo.toml?

29 remaining items

added a commit that references this issue on May 1, 2023
dcef3b7
added a commit that references this issue on May 2, 2023
f379a58
ehuss

ehuss commented on May 6, 2023

@ehuss
Contributor

I'm concerned about the stabilization of this feature in its current state. I filed a few issues (see F-debugger_visualizer `#![feature(debugger_visualizer)]` ). It is almost unusable for the purpose of authoring visualizers since you can't modify a file without needing to delete your build directory and starting over. I would recommend looking at either fixing those issues or considering to revert the stabilization, since otherwise I think it would provide a poor first impression.

added
I-compiler-nominatedNominated for discussion during a compiler team meeting.
on May 7, 2023
lcnr

lcnr commented on May 7, 2023

@lcnr
Contributor

nominating for t-compiler meeting due to the above concern. if we're able to remove this asynchronously before then we can always remove the nomination.

reopened this on May 7, 2023
michaelwoerister

michaelwoerister commented on May 8, 2023

@michaelwoerister
Member

I agree that these issue are a blocking concern for the feature. If I'm reading the schedule right, we have until May 26 to either fix the issue or revert stabilization.

michaelwoerister

michaelwoerister commented on May 11, 2023

@michaelwoerister
Member

Thanks for opening the issues, @ehuss! I've assigned myself to do an initial investigation.

apiraino

apiraino commented on May 18, 2023

@apiraino
Contributor

Discussed in T-compiler meeting on Zulip

Linking #111641 that should address this.

@rustbot label -I-compiler-nominated

Mark-Simulacrum

Mark-Simulacrum commented on Jul 1, 2023

@Mark-Simulacrum
Member

Closing this tracking issue -- I believe the feature is now stabilized, and the concerns raised were addressed.

removed
S-tracking-needs-to-bakeStatus: The implementation is "complete" but it needs time to bake.
on Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCF-debugger_visualizer`#![feature(debugger_visualizer)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-langRelevant to the language teamdisposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @ehuss@nikomatsakis@joshtriplett@pravic@wesleywiser

    Issue actions

      Tracking Issue for `debugger_visualizer` · Issue #95939 · rust-lang/rust