Skip to content

rustfmt no longer builds after rust-lang/rust#68907 #68917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rust-highfive opened this issue Feb 7, 2020 · 1 comment · Fixed by #69097
Closed

rustfmt no longer builds after rust-lang/rust#68907 #68917

rust-highfive opened this issue Feb 7, 2020 · 1 comment · Fixed by #69097
Assignees
@topecongiro
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #68907, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Dylan-DPC, the PR reviewer, and nominating for compiler team prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 7, 2020
@matthiaskrgr matthiaskrgr mentioned this issue Feb 7, 2020
Merged
@calebcartwright calebcartwright mentioned this issue Feb 9, 2020
Merged
@calebcartwright
Copy link
Member

@topecongiro - I've opened rust-lang/rustfmt#4043 to fix this against rustfmt 1.4.11 since I don't think we're ready to start publishing the 2.x version yet.

rust-lang/rustfmt#4022 is also there to fix things on master/2.x

@matthiaskrgr matthiaskrgr mentioned this issue Feb 10, 2020
Merged
@calebcartwright calebcartwright mentioned this issue Feb 11, 2020
Merged
@SimonSapin SimonSapin mentioned this issue Feb 12, 2020
Merged
@Xanewok Xanewok mentioned this issue Feb 12, 2020
Merged
@bors bors closed this as completed in ba18875 Feb 13, 2020
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
f68551e 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
53d130b 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
2d5bbf0 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
30f43fa 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
24de9a1 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
3f054d9 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
bors-servo pushed a commit to servo/servo that referenced this issue Feb 14, 2020
Auto merge of #25739 - servo:rustup, r=paulrouget
55473eb 
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RLS and Rustfmt Xanewok/rust
3 participants
@rust-highfive @calebcartwright @topecongiro