Skip to content

compiletest: previously-succeeding tests are still rerun. #57864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eddyb opened this issue Jan 23, 2019 · 4 comments
Closed

compiletest: previously-succeeding tests are still rerun. #57864

eddyb opened this issue Jan 23, 2019 · 4 comments
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@eddyb
Copy link
Member

eddyb commented Jan 23, 2019

Running e.g. ./x.py test --stage 1 src/test/mir-opt several times currently results in all the tests being ran every single time, instead of skipping those that succeeded already.

I'm not sure when this started happening, but it's recent, somewhere in the past few weeks.
It could perhaps be caused by #56680, although I don't recall having issues around the time that PR was merged. Also, I have no indication that anyone else has this issue, could be my build dir.

cc @Mark-Simulacrum

@euclio
Copy link
Contributor

euclio commented Jan 23, 2019

See #57529 as well.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 23, 2019

I can confirm this happening on my machine, too. I've only had this for a few days though (definitely not last week) and I rebase very frequently

@Mark-Simulacrum
Copy link
Member

I will attempt to investigate this tonight and try and get a fix out soon, but not sure yet if I'll have the time.

@Mark-Simulacrum
Copy link
Member

I've posted the fix at #57871

@Mark-Simulacrum Mark-Simulacrum self-assigned this Jan 24, 2019
@estebank estebank added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 24, 2019
@bors bors closed this as completed in 4916801 Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

5 participants