Skip to content

[1.30 beta] More chars considered alphanumeric in 1.30 #54481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pietroalbini opened this issue Sep 22, 2018 · 5 comments
Closed

[1.30 beta] More chars considered alphanumeric in 1.30 #54481

pietroalbini opened this issue Sep 22, 2018 · 5 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@pietroalbini
Copy link
Member

More chars are considered alphanumeric in 1.30 (like ²), so the test suite of a few crates is failing.

@pietroalbini pietroalbini added I-nominated T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. C-bug Category: This is a bug. labels Sep 22, 2018
@pietroalbini pietroalbini added this to the 1.30 milestone Sep 22, 2018
@cuviper
Copy link
Member

cuviper commented Sep 24, 2018

This appears to be a deliberate change, #51609.
cc @rust-lang/libs

@alexcrichton
Copy link
Member

I've put this on our agenda to discuss, thanks for the cc!

@SimonSapin
Copy link
Contributor

char::is_alphanumeric is only used in munch in a test. The test happened to use ² as a character where that method was expected to return false, but there doesn’t seem to be a reason why this couldn’t be any other character, like some punctuation. The test is not about alphanumeric-ness, that’s just a char -> bool function that happened to be readily available.

I was somewhat ambivalent about #51609, but now that it’s landed I don’t think this particular regression is something to worry about.

@alexcrichton
Copy link
Member

Ok discussed during triage and we've decided to close, but again anyone please let us know if it's difficult to update!

@utkarshkukreti
Copy link
Contributor

Hi! I'm the author of the only crate affected by this. This only breaks a couple of tests and not any actual functionality like SimonSapin said and I don't mind modifying the tests to accommodate this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants