Skip to content

CI: Remove the concept of "Disabled builders" #49700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennytm opened this issue Apr 5, 2018 · 1 comment
Closed

CI: Remove the concept of "Disabled builders" #49700

kennytm opened this issue Apr 5, 2018 · 1 comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@kennytm
Copy link
Member

kennytm commented Apr 5, 2018

Disabled builders were introduced in #41864. These are Docker images which are explicitly prevented from being run from Travis. However,

  1. Since we are going to explicitly list all images in .travis.yml, there seems no reason to introduce a disabled/ folder
  2. We may really want to run these images on Travis as a try-build.

Nowadays, Travis supports conditional jobs, so we could actually

  1. Move those disabled builders back into the normal location

  2. Revert specialization in src/ci/docker/run.sh about disabled images

  3. Expose them to .travis.yml but disable them via conditions:

        - env: IMAGE=aarch64-gnu
          if: type = disabled     # <- this condition is always false

The motivation is allowing check builders of tier-2/3 platforms (e.g. Redox, CloudABI, the embedded platforms etc) be run on demand.

@kennytm kennytm added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Apr 5, 2018
@JohnTitor
Copy link
Member

Triage: We're now on GHA and the config should be cleaned up, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants