Skip to content

rmp-serde-0.13.1 beta regression #43687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
est31 opened this issue Aug 5, 2017 · 2 comments
Closed

rmp-serde-0.13.1 beta regression #43687

est31 opened this issue Aug 5, 2017 · 2 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

rmp-serde version 0.13.1 regressed from stable to beta (full log):

Aug 04 09:41:39.372 INFO kablam! error: type `decode::SliceReader<'a>` is private
Aug 04 09:41:39.372 INFO kablam!    --> /cargo-home/registry/src/github.com-1ecc6299db9ec823/rmp-serde-0.13.1/src/lib.rs:285:18
Aug 04 09:41:39.372 INFO kablam!     |
Aug 04 09:41:39.372 INFO kablam! 285 |     let mut de = Deserializer::from_slice(input);
Aug 04 09:41:39.372 INFO kablam!     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Aug 04 09:41:39.372 INFO kablam!

cc @3Hren

This broke @euclio 's https://github.com/euclio/vim-markdown-composer at commit euclio/vim-markdown-composer@ba8799c
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

duplicate of 3Hren/msgpack-rust#131, fixed in rmp-serde 0.13.3

euclio added a commit to euclio/vim-markdown-composer that referenced this issue Aug 5, 2017
@euclio
update dependencies
8e98c7b 
Picks up fix for rust-lang/rust#43687 on beta.
@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@est31
Copy link
Member Author

est31 commented Aug 5, 2017 •
edited
Loading

I guess euclio/vim-markdown-composer@8e98c7b fixed this. Thanks @euclio !

@est31 est31 closed this as completed Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arielb1 @est31