Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove hardcoded compiler-builtins-mem feature for armv7a-vex-v5 once compiler-builtins can automatically add it. #136076

Closed
Tropix126 opened this issue Jan 26, 2025 · 1 comment
Closed

cleanup: Remove hardcoded compiler-builtins-mem feature for armv7a-vex-v5 once compiler-builtins can automatically add it. #136076

Tropix126 opened this issue Jan 26, 2025 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Tropix126
Copy link

PR #131530 adds the armv7a-vex-v5 Tier 3 target, which operates outside of a libc enviornment. As such as we aren't provided symbols like memcpy, memmove, etc... and require the compiler-builtins-mem feature. In the PR, we hardcode bootstrap to automatically add the feature when target.contains("vex"). The zkvm family of targets also does this.

Once compiler-builtins is able to automatically detect the target, this check should be removed.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 26, 2025
@Tropix126 Tropix126 changed the title cleanup: Remove hardcoded compiler-builtins-mem feature addition for armv7a-vex-v5 once compiler-builtins can automatically add it. cleanup: Remove hardcoded compiler-builtins-mem feature for armv7a-vex-v5 once compiler-builtins can automatically add it. Jan 26, 2025
@lolbinarycat lolbinarycat added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 26, 2025
@Tropix126
Copy link
Author

Closing due to #131530 being closed and hopefully split into smaller changes in the future. This will be addressed at a later time.

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolbinarycat @jieyouxu @Tropix126 @rustbot