-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Test failures in tests/ui/panics
on aarch64-apple-darwin
#133997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm seeing the same failures with all of:
|
I cannot repro on x86_64 linux, x86_64 msvc, aarch64 linux, tagging aarch64 + apple unless someone else can repro this on a different environment. |
I can also confirm that for me the tests pass before #123244, and fail after it. |
#123244 added some additional normalizations, FTR |
We probably(?) need some extra normalization in the tests. The symbol in question (begin_panic) is probably found a bit differently by backtrace on this platform? That said, we run these tests in CI for this platform, so it's not clear whether it's some local delta as well. Perhaps you have e.g. lld enabled or some other optimization setting that's not set in CI? |
I can reproduce it on my machine too (also using macOS 14.7.1), on both Aarch64 and x86_64 (using Rosetta), so that's at least weak evidence that it's not something environment specific. Not sure what the underlying issue is yet though. |
I can make the failures go away by setting That helps to explain why it doesn't show up on CI. |
…ieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
…ieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
Rollup merge of rust-lang#134781 - Zalathar:backtrace, r=SparrowLii,jieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
Fixed by adding more normalizations in #134781. |
…ieyouxu Add more `begin_panic` normalizations to panic backtrace tests Since rust-lang#123244, these tests have started failing locally on some systems (rust-lang#133997) due to minor variations in how `begin_panic` is printed in the backtrace. The variation appears to occur on macOS when `rust.debuginfo-level = "line-tables-only"` is set, which is the default in `config.compiler.toml`. It does not occur when the debuginfo level is set to 1. The variation doesn't seem relevant to these tests, so this PR simply adds another custom normalization rule to account for the variation. --- Will conflict with rust-lang#134759.
Using an unmodified
profile = "compiler"
build on aarch64 macOS (14.7.1), I see the following tests fail from./x test tests/ui/panics
:All of the failure diffs look something like this:
I see the same failures with
--stage=1
and--stage=2
.Not sure if this is a test output normalization problem, or an actual bug.
Discussion elsewhere indicates that this might be related to #123244.
The text was updated successfully, but these errors were encountered: