#[allow(unused_parens)] no longer required

tautschnig · tautschnig · commit f47406e90789 · 2025-10-29T12:19:58.000Z
diff --git a/library/alloc/src/collections/vec_deque/iter.rs b/library/alloc/src/collections/vec_deque/iter.rs
@@ -144,7 +144,6 @@ impl<'a, T> Iterator for Iter<'a, T> {
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.len())]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item {
         // Safety: The TrustedRandomAccess contract requires that callers only pass an index
diff --git a/library/alloc/src/vec/into_iter.rs b/library/alloc/src/vec/into_iter.rs
@@ -360,7 +360,6 @@ impl<T, A: Allocator> Iterator for IntoIter<T, A> {
         R::from_output(accum)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(i < self.len())]
     unsafe fn __iterator_get_unchecked(&mut self, i: usize) -> Self::Item
     where
diff --git a/library/core/src/alloc/layout.rs b/library/core/src/alloc/layout.rs
@@ -136,7 +136,6 @@ impl Layout {
     #[inline]
     #[track_caller]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(Layout::from_size_align(size, align).is_ok())]
     #[core::contracts::ensures(
         move |result: &Self| result.size() == size && result.align() == align)]
@@ -200,7 +199,6 @@ impl Layout {
     #[must_use]
     #[inline]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(mem::align_of_val(t).is_power_of_two())]
     // FIXME: requires `&self` to be `'static`
     // #[core::contracts::ensures(move |result: &Self| result.align() == mem::align_of_val(t))]
diff --git a/library/core/src/array/iter.rs b/library/core/src/array/iter.rs
@@ -139,7 +139,6 @@ impl<T, const N: usize> IntoIter<T, N> {
     #[unstable(feature = "array_into_iter_constructors", issue = "91583")]
     #[inline]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(initialized.start <= initialized.end && initialized.end <= N)]
     pub const unsafe fn new_unchecked(
         buffer: [MaybeUninit<T>; N],
@@ -282,7 +281,6 @@ impl<T, const N: usize> Iterator for IntoIter<T, N> {
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.len())]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item {
         // SAFETY: The caller must provide an idx that is in bound of the remainder.
diff --git a/library/core/src/ascii/ascii_char.rs b/library/core/src/ascii/ascii_char.rs
@@ -480,7 +480,6 @@ impl AsciiChar {
     #[unstable(feature = "ascii_char", issue = "110998")]
     #[inline]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(b <= 127)]
     #[core::contracts::ensures(move |result: &Self| *result as u8 == b)]
     pub const unsafe fn from_u8_unchecked(b: u8) -> Self {
@@ -525,7 +524,6 @@ impl AsciiChar {
     // `assert_unsafe_precondition` inside. See https://github.com/rust-lang/rust/pull/129374 for
     // some context about the discrepancy.
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(d < 10)]
     pub const unsafe fn digit_unchecked(d: u8) -> Self {
         assert_unsafe_precondition!(
diff --git a/library/core/src/char/convert.rs b/library/core/src/char/convert.rs
@@ -24,7 +24,6 @@ pub(super) const fn from_u32(i: u32) -> Option<char> {
 #[allow(unnecessary_transmutes)]
 #[track_caller]
 #[rustc_allow_const_fn_unstable(contracts)]
-#[allow(unused_parens)]
 #[core::contracts::requires(char_try_from_u32(i).is_ok())]
 #[core::contracts::ensures(move |result: &char| *result as u32 == i)]
 pub(super) const unsafe fn from_u32_unchecked(i: u32) -> char {
diff --git a/library/core/src/char/mod.rs b/library/core/src/char/mod.rs
@@ -139,7 +139,6 @@ pub const fn from_u32(i: u32) -> Option<char> {
 #[must_use]
 #[inline]
 #[rustc_allow_const_fn_unstable(contracts)]
-#[allow(unused_parens)]
 #[core::contracts::requires(i <= 0x10FFFF && (i < 0xD800 || i > 0xDFFF))]
 pub const unsafe fn from_u32_unchecked(i: u32) -> char {
     // SAFETY: the safety contract must be upheld by the caller.
@@ -537,7 +536,6 @@ impl Iterator for CaseMappingIter {
         self.0.advance_by(n)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.len())]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item {
         // SAFETY: just forwarding requirements to caller
diff --git a/library/core/src/ffi/c_str.rs b/library/core/src/ffi/c_str.rs
@@ -251,7 +251,6 @@ impl CStr {
     #[stable(feature = "rust1", since = "1.0.0")]
     #[rustc_const_stable(feature = "const_cstr_from_ptr", since = "1.81.0")]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(!ptr.is_null())]
     #[core::contracts::ensures(
         |result: &&CStr|
@@ -394,7 +393,6 @@ impl CStr {
     #[rustc_const_stable(feature = "const_cstr_unchecked", since = "1.59.0")]
     #[rustc_allow_const_fn_unstable(const_eval_select)]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         !bytes.is_empty() && bytes[bytes.len() - 1] == 0 && !bytes[..bytes.len()-1].contains(&0))]
     #[core::contracts::ensures(
diff --git a/library/core/src/intrinsics/mod.rs b/library/core/src/intrinsics/mod.rs
@@ -2563,7 +2563,6 @@ pub const fn is_val_statically_known<T: Copy>(_arg: T) -> bool {
 #[inline]
 #[rustc_intrinsic]
 #[rustc_intrinsic_const_stable_indirect]
-#[allow(unused_parens)]
 #[rustc_allow_const_fn_unstable(contracts)]
 #[core::contracts::requires(x.addr() != y.addr() || core::mem::size_of::<T>() == 0)]
 pub const unsafe fn typed_swap_nonoverlapping<T>(x: *mut T, y: *mut T) {
diff --git a/library/core/src/iter/adapters/cloned.rs b/library/core/src/iter/adapters/cloned.rs
@@ -61,7 +61,6 @@ where
         self.it.map(T::clone).fold(init, f)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.it.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> T
     where
diff --git a/library/core/src/iter/adapters/copied.rs b/library/core/src/iter/adapters/copied.rs
@@ -92,7 +92,6 @@ where
         self.it.advance_by(n)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.it.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> T
     where
diff --git a/library/core/src/iter/adapters/enumerate.rs b/library/core/src/iter/adapters/enumerate.rs
@@ -160,7 +160,6 @@ where
 
     #[rustc_inherit_overflow_checks]
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.iter.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> <Self as Iterator>::Item
     where
diff --git a/library/core/src/iter/adapters/fuse.rs b/library/core/src/iter/adapters/fuse.rs
@@ -109,7 +109,6 @@ where
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         self.iter.is_some() && idx < self.iter.as_ref().unwrap().size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item
diff --git a/library/core/src/iter/adapters/map.rs b/library/core/src/iter/adapters/map.rs
@@ -129,7 +129,6 @@ where
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.iter.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> B
     where
diff --git a/library/core/src/iter/adapters/skip.rs b/library/core/src/iter/adapters/skip.rs
@@ -158,7 +158,6 @@ where
     }
 
     #[doc(hidden)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx + self.n < self.iter.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item
     where
diff --git a/library/core/src/iter/adapters/zip.rs b/library/core/src/iter/adapters/zip.rs
@@ -104,7 +104,6 @@ where
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item
     where
diff --git a/library/core/src/iter/range.rs b/library/core/src/iter/range.rs
@@ -499,7 +499,6 @@ impl Step for char {
         Some(unsafe { char::from_u32_unchecked(res) })
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         (start as u32).checked_add(count as u32).is_some_and(|dist|
             (start as u32) >= 0xD800 ||
@@ -521,7 +520,6 @@ impl Step for char {
         unsafe { char::from_u32_unchecked(res) }
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         (start as u32).checked_sub(count as u32).is_some_and(|dist|
             (start as u32) < 0xE000 ||
@@ -565,7 +563,6 @@ impl Step for AsciiChar {
         Some(unsafe { AsciiChar::from_u8_unchecked(end) })
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(count < 256 && start.to_u8().checked_add(count as u8).is_some())]
     #[inline]
     unsafe fn forward_unchecked(start: AsciiChar, count: usize) -> AsciiChar {
@@ -577,7 +574,6 @@ impl Step for AsciiChar {
         unsafe { AsciiChar::from_u8_unchecked(end) }
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(count < 256 && start.to_u8().checked_sub(count as u8).is_some())]
     #[inline]
     unsafe fn backward_unchecked(start: AsciiChar, count: usize) -> AsciiChar {
@@ -607,7 +603,6 @@ impl Step for Ipv4Addr {
         u32::backward_checked(start.to_bits(), count).map(Ipv4Addr::from_bits)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(start.to_bits().checked_add(count as u32).is_some())]
     #[inline]
     unsafe fn forward_unchecked(start: Ipv4Addr, count: usize) -> Ipv4Addr {
@@ -616,7 +611,6 @@ impl Step for Ipv4Addr {
         Ipv4Addr::from_bits(unsafe { u32::forward_unchecked(start.to_bits(), count) })
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(start.to_bits().checked_sub(count as u32).is_some())]
     #[inline]
     unsafe fn backward_unchecked(start: Ipv4Addr, count: usize) -> Ipv4Addr {
@@ -643,7 +637,6 @@ impl Step for Ipv6Addr {
         u128::backward_checked(start.to_bits(), count).map(Ipv6Addr::from_bits)
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(start.to_bits().checked_add(count as u128).is_some())]
     #[inline]
     unsafe fn forward_unchecked(start: Ipv6Addr, count: usize) -> Ipv6Addr {
@@ -652,7 +645,6 @@ impl Step for Ipv6Addr {
         Ipv6Addr::from_bits(unsafe { u128::forward_unchecked(start.to_bits(), count) })
     }
 
-    #[allow(unused_parens)]
     #[core::contracts::requires(start.to_bits().checked_sub(count as u128).is_some())]
     #[inline]
     unsafe fn backward_unchecked(start: Ipv6Addr, count: usize) -> Ipv6Addr {
@@ -933,7 +925,6 @@ impl<A: Step> Iterator for ops::Range<A> {
     }
 
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(idx < self.size_hint().0)]
     unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item
     where
diff --git a/library/core/src/iter/traits/iterator.rs b/library/core/src/iter/traits/iterator.rs
@@ -1710,7 +1710,6 @@ pub trait Iterator {
     /// ```
     #[inline]
     #[unstable(feature = "iter_map_windows", reason = "recently added", issue = "87155")]
-    #[allow(unused_parens)]
     #[core::contracts::requires(N > 0)]
     fn map_windows<F, R, const N: usize>(self, f: F) -> MapWindows<Self, F, N>
     where
diff --git a/library/core/src/num/f128.rs b/library/core/src/num/f128.rs
@@ -875,7 +875,6 @@ impl f128 {
     #[inline]
     #[unstable(feature = "f128", issue = "116909")]
     #[must_use = "this returns the result of the operation, without modifying the original"]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.is_finite())]
     pub unsafe fn to_int_unchecked<Int>(self) -> Int
     where
diff --git a/library/core/src/num/f16.rs b/library/core/src/num/f16.rs
@@ -862,7 +862,6 @@ impl f16 {
     #[inline]
     #[unstable(feature = "f16", issue = "116909")]
     #[must_use = "this returns the result of the operation, without modifying the original"]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.is_finite())]
     pub unsafe fn to_int_unchecked<Int>(self) -> Int
     where
diff --git a/library/core/src/num/f32.rs b/library/core/src/num/f32.rs
@@ -1066,7 +1066,6 @@ impl f32 {
                   without modifying the original"]
     #[stable(feature = "float_approx_unchecked_to", since = "1.44.0")]
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.is_finite())]
     pub unsafe fn to_int_unchecked<Int>(self) -> Int
     where
diff --git a/library/core/src/num/f64.rs b/library/core/src/num/f64.rs
@@ -1065,7 +1065,6 @@ impl f64 {
                   without modifying the original"]
     #[stable(feature = "float_approx_unchecked_to", since = "1.44.0")]
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.is_finite())]
     pub unsafe fn to_int_unchecked<Int>(self) -> Int
     where
diff --git a/library/core/src/num/mod.rs b/library/core/src/num/mod.rs
@@ -505,7 +505,6 @@ impl u8 {
     #[must_use]
     #[unstable(feature = "ascii_char", issue = "110998")]
     #[inline]
-    #[allow(unused_parens)]
     #[rustc_allow_const_fn_unstable(contracts)]
     #[core::contracts::requires(self.is_ascii())]
     pub const unsafe fn as_ascii_unchecked(&self) -> ascii::Char {
diff --git a/library/core/src/num/nonzero.rs b/library/core/src/num/nonzero.rs
@@ -411,7 +411,6 @@ where
     #[must_use]
     #[inline]
     #[track_caller]
-    #[allow(unused_parens)]
     #[rustc_allow_const_fn_unstable(contracts)]
     #[core::contracts::requires({
         let size = core::mem::size_of::<T>();
@@ -460,7 +459,6 @@ where
     #[must_use]
     #[inline]
     #[track_caller]
-    #[allow(unused_parens)]
     #[core::contracts::requires({
         let size = core::mem::size_of::<T>();
         let ptr = n as *const T as *const u8;
diff --git a/library/core/src/ops/index_range.rs b/library/core/src/ops/index_range.rs
@@ -21,7 +21,6 @@ impl IndexRange {
     #[inline]
     #[track_caller]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(start <= end)]
     pub(crate) const unsafe fn new_unchecked(start: usize, end: usize) -> Self {
         ub_checks::assert_unsafe_precondition!(
@@ -57,7 +56,6 @@ impl IndexRange {
     /// # Safety
     /// - Can only be called when `start < end`, aka when `len > 0`.
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.start < self.end)]
     unsafe fn next_unchecked(&mut self) -> usize {
         debug_assert!(self.start < self.end);
@@ -71,7 +69,6 @@ impl IndexRange {
     /// # Safety
     /// - Can only be called when `start < end`, aka when `len > 0`.
     #[inline]
-    #[allow(unused_parens)]
     #[core::contracts::requires(self.start < self.end)]
     unsafe fn next_back_unchecked(&mut self) -> usize {
         debug_assert!(self.start < self.end);
diff --git a/library/core/src/ptr/const_ptr.rs b/library/core/src/ptr/const_ptr.rs
@@ -347,7 +347,6 @@ impl<T: PointeeSized> *const T {
     #[inline(always)]
     #[track_caller]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         // Precondition 1: the computed offset `count * size_of::<T>()` does not overflow `isize`.
         // Precondition 2: adding the computed offset to `self` does not cause overflow.
@@ -617,7 +616,6 @@ impl<T: PointeeSized> *const T {
     #[inline]
     #[cfg_attr(miri, track_caller)] // even without panics, this helps for Miri backtraces
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         // Ensures subtracting `origin` from `self` doesn't overflow
         (self as isize).checked_sub(origin as isize).is_some() &&
@@ -845,7 +843,6 @@ impl<T: PointeeSized> *const T {
     #[inline(always)]
     #[track_caller]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         // Precondition 1: the computed offset `count * size_of::<T>()` does not overflow `isize`.
         // Precondition 2: adding the computed offset to `self` does not cause overflow.
@@ -960,7 +957,6 @@ impl<T: PointeeSized> *const T {
     #[inline(always)]
     #[track_caller]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(
         // Precondition 1: the computed offset `count * size_of::<T>()` does not overflow `isize`.
         // Precondition 2: subtracting the computed offset from `self` does not cause overflow.
diff --git a/library/core/src/ptr/mod.rs b/library/core/src/ptr/mod.rs
@@ -2224,7 +2224,6 @@ pub unsafe fn write_volatile<T>(dst: *mut T, src: T) {
 ///
 /// Any questions go to @nagisa.
 #[allow(ptr_to_integer_transmute_in_consts)]
-#[allow(unused_parens)]
 #[core::contracts::requires(a.is_power_of_two())]
 // FIXME: requires `T` to be `'static`
 // #[core::contracts::ensures(move |result| {
@@ -2278,7 +2277,6 @@ pub(crate) unsafe fn align_offset<T: Sized>(p: *const T, a: usize) -> usize {
     /// Implementation of this function shall not panic. Ever.
     #[inline]
     #[rustc_allow_const_fn_unstable(contracts)]
-    #[allow(unused_parens)]
     #[core::contracts::requires(m.is_power_of_two() && x < m && x % 2 != 0)]
     #[core::contracts::ensures(move |result| wrapping_mul(*result, x) % m == 1)]
     const unsafe fn mod_inv(x: usize, m: usize) -> usize {
diff --git a/library/core/src/ptr/mut_ptr.rs b/library/core/src/ptr/mut_ptr.rs
diff --git a/library/core/src/ptr/non_null.rs b/library/core/src/ptr/non_null.rs
diff --git a/library/core/src/ptr/unique.rs b/library/core/src/ptr/unique.rs
diff --git a/library/core/src/range/iter.rs b/library/core/src/range/iter.rs
diff --git a/library/core/src/slice/iter.rs b/library/core/src/slice/iter.rs
diff --git a/library/core/src/str/iter.rs b/library/core/src/str/iter.rs
diff --git a/library/core/src/str/pattern.rs b/library/core/src/str/pattern.rs
diff --git a/library/std/src/alloc.rs b/library/std/src/alloc.rs
diff --git a/library/std/src/sync/mpmc/context.rs b/library/std/src/sync/mpmc/context.rs

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,6 @@ impl<'a, T> Iterator for Iter<'a, T> {`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`#[inline]`
`147`		`- #[allow(unused_parens)]`
`148`	`147`	`#[core::contracts::requires(idx < self.len())]`
`149`	`148`	`unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item {`
`150`	`149`	`// Safety: The TrustedRandomAccess contract requires that callers only pass an index`
Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,6 @@ impl<T, A: Allocator> Iterator for IntoIter<T, A> {`
`360`	`360`	`R::from_output(accum)`
`361`	`361`	`}`
`362`	`362`
`363`		`- #[allow(unused_parens)]`
`364`	`363`	`#[core::contracts::requires(i < self.len())]`
`365`	`364`	`unsafe fn __iterator_get_unchecked(&mut self, i: usize) -> Self::Item`
`366`	`365`	`where`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ where`
`61`	`61`	`self.it.map(T::clone).fold(init, f)`
`62`	`62`	`}`
`63`	`63`
`64`		`- #[allow(unused_parens)]`
`65`	`64`	`#[core::contracts::requires(idx < self.it.size_hint().0)]`
`66`	`65`	`unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> T`
`67`	`66`	`where`