Skip to content

Commit d720ced

Browse files
committed
add fixme for trait declarations
1 parent cd3ca0b commit d720ced

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

src/librustc_incremental/persist/dirty_clean.rs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,18 @@ impl<'a, 'tcx> DirtyCleanVisitor<'a, 'tcx> {
400400
HirItem::ItemUnion(..) => ("ItemUnion", &LABELS_STRUCT),
401401

402402
// Represents a Trait Declaration
403-
HirItem::ItemTrait(..) => ("ItemTrait", &LABELS_TRAIT),
403+
// FIXME(vitiral): trait declaration is buggy as hell because sometimes some of
404+
// the depnodes don't exist (because they legitametely didn't need to be
405+
// calculated)
406+
//
407+
// michaelwoerister and myself came up with a possible solution,
408+
// to just do this before every query
409+
// ```
410+
// ::rustc::ty::maps::plumbing::force_from_dep_node(tcx, dep_node)
411+
// ```
412+
// We are waiting on feedback from compiler team
413+
//
414+
//HirItem::ItemTrait(..) => ("ItemTrait", &LABELS_TRAIT),
404415

405416
// `impl Trait for .. {}`
406417
HirItem::ItemDefaultImpl(..) => ("ItemDefaultImpl", &LABELS_IMPL),

0 commit comments

Comments
 (0)