Mark "unused binding" suggestion as maybe incorrect

estebank · estebank · commit 949a60c72fb1 · 2024-01-29T18:54:29.000Z
Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change. Fix #54196.
diff --git a/compiler/rustc_passes/src/errors.rs b/compiler/rustc_passes/src/errors.rs
@@ -1778,7 +1778,7 @@ pub struct UnusedVarTryIgnore {
 }
 
 #[derive(Subdiagnostic)]
-#[multipart_suggestion(passes_suggestion, applicability = "machine-applicable")]
+#[multipart_suggestion(passes_suggestion, applicability = "maybe-incorrect")]
 pub struct UnusedVarTryIgnoreSugg {
     #[suggestion_part(code = "{name}: _")]
     pub shorthands: Vec<Span>,

Original file line number	Diff line number	Diff line change
`@@ -1778,7 +1778,7 @@ pub struct UnusedVarTryIgnore {`
`1778`	`1778`	`}`
`1779`	`1779`
`1780`	`1780`	`#[derive(Subdiagnostic)]`
`1781`		`-#[multipart_suggestion(passes_suggestion, applicability = "machine-applicable")]`
	`1781`	`+#[multipart_suggestion(passes_suggestion, applicability = "maybe-incorrect")]`
`1782`	`1782`	`pub struct UnusedVarTryIgnoreSugg {`
`1783`	`1783`	`#[suggestion_part(code = "{name}: _")]`
`1784`	`1784`	`pub shorthands: Vec<Span>,`