Only cache typeck results if it's the typeck root

compiler-errors · compiler-errors · commit 938e80781651 · 2023-04-30T19:36:59.000Z
diff --git a/compiler/rustc_middle/src/query/mod.rs b/compiler/rustc_middle/src/query/mod.rs
@@ -875,7 +875,7 @@ rustc_queries! {
 
     query typeck(key: LocalDefId) -> &'tcx ty::TypeckResults<'tcx> {
         desc { |tcx| "type-checking `{}`", tcx.def_path_str(key) }
-        cache_on_disk_if { true }
+        cache_on_disk_if(tcx) { !tcx.is_typeck_child(key.to_def_id()) }
     }
     query diagnostic_only_typeck(key: LocalDefId) -> &'tcx ty::TypeckResults<'tcx> {
         desc { |tcx| "type-checking `{}`", tcx.def_path_str(key) }

Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,7 @@ rustc_queries! {`
`875`	`875`
`876`	`876`	`query typeck(key: LocalDefId) -> &'tcx ty::TypeckResults<'tcx> {`
`877`	`877`	desc { \|tcx\| "type-checking `{}`", tcx.def_path_str(key) }
`878`		`- cache_on_disk_if { true }`
	`878`	`+ cache_on_disk_if(tcx) { !tcx.is_typeck_child(key.to_def_id()) }`
`879`	`879`	`}`
`880`	`880`	`query diagnostic_only_typeck(key: LocalDefId) -> &'tcx ty::TypeckResults<'tcx> {`
`881`	`881`	desc { \|tcx\| "type-checking `{}`", tcx.def_path_str(key) }