make the default binding mode label point to where the & goes

dianne · dianne · commit 91108b02ee0e · 2025-02-05T01:36:05.000-08:00
diff --git a/compiler/rustc_mir_build/src/errors.rs b/compiler/rustc_mir_build/src/errors.rs
@@ -1137,8 +1137,11 @@ impl Subdiagnostic for Rust2024IncompatiblePatSugg {
                     def_br_mutbl.ref_prefix_str()
                 );
                 let label_msg = format!("the default binding mode is `{dbm_str}`, introduced here");
-                let mut label = MultiSpan::from(span);
-                label.push_span_label(span, label_msg);
+                // Get a ^---- label with the ^ pointing to where the user would write `&` or `&mut`
+                let imaginary_ref_span = span.shrink_to_lo();
+                let mut label = MultiSpan::from(imaginary_ref_span);
+                label.push_span_label(imaginary_ref_span, label_msg);
+                label.push_span_label(span, "");
                 diag.span_note(label, note_msg);
             }
         }
diff --git a/tests/ui/pattern/rfc-3627-match-ergonomics-2024/experimental/ref-binding-on-inh-ref-errors.classic2024.stderr b/tests/ui/pattern/rfc-3627-match-ergonomics-2024/experimental/ref-binding-on-inh-ref-errors.classic2024.stderr
@@ -21,7 +21,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:67:9
    |
 LL |     let [ref mut x] = &[0];
-   |         ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[ref mut x] = &[0];
@@ -44,7 +46,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:75:9
    |
 LL |     let [ref x] = &[0];
-   |         ^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[ref x] = &[0];
@@ -61,7 +65,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:79:9
    |
 LL |     let [ref x] = &mut [0];
-   |         ^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [ref x] = &mut [0];
@@ -78,7 +84,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:83:9
    |
 LL |     let [ref mut x] = &mut [0];
-   |         ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [ref mut x] = &mut [0];
diff --git a/tests/ui/pattern/rfc-3627-match-ergonomics-2024/experimental/ref-binding-on-inh-ref-errors.structural2024.stderr b/tests/ui/pattern/rfc-3627-match-ergonomics-2024/experimental/ref-binding-on-inh-ref-errors.structural2024.stderr
@@ -9,7 +9,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:15:9
    |
 LL |     let [&ref x] = &[&0];
-   |         ^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^-------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[&ref x] = &[&0];
@@ -26,7 +28,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:20:9
    |
 LL |     let [&ref x] = &mut [&0];
-   |         ^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^-------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [&ref x] = &mut [&0];
@@ -43,7 +47,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:25:9
    |
 LL |     let [&mut ref x] = &mut [&mut 0];
-   |         ^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^-----------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [&mut ref x] = &mut [&mut 0];
@@ -60,7 +66,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:30:9
    |
 LL |     let [&mut ref mut x] = &mut [&mut 0];
-   |         ^^^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^---------------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [&mut ref mut x] = &mut [&mut 0];
@@ -77,7 +85,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:39:9
    |
 LL |     let [&ref x] = &[&mut 0];
-   |         ^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^-------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[&ref x] = &[&mut 0];
@@ -94,7 +104,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:45:9
    |
 LL |     let [&ref x] = &mut [&mut 0];
-   |         ^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^-------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [&ref x] = &mut [&mut 0];
@@ -111,7 +123,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:54:9
    |
 LL |     let [&mut ref x] = &[&mut 0];
-   |         ^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^-----------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[&mut ref x] = &[&mut 0];
@@ -128,7 +142,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:67:9
    |
 LL |     let [ref mut x] = &[0];
-   |         ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[ref mut x] = &[0];
@@ -151,7 +167,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/ref-binding-on-inh-ref-errors.rs:75:9
    |
 LL |     let [ref x] = &[0];
-   |         ^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[ref x] = &[0];
@@ -168,7 +186,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:79:9
    |
 LL |     let [ref x] = &mut [0];
-   |         ^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [ref x] = &mut [0];
@@ -185,7 +205,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/ref-binding-on-inh-ref-errors.rs:83:9
    |
 LL |     let [ref mut x] = &mut [0];
-   |         ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut [ref mut x] = &mut [0];
diff --git a/tests/ui/pattern/rfc-3627-match-ergonomics-2024/migration_lint.stderr b/tests/ui/pattern/rfc-3627-match-ergonomics-2024/migration_lint.stderr
@@ -10,7 +10,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:25:9
    |
 LL |     let Foo(mut x) = &Foo(0);
-   |         ^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^---------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 note: the lint level is defined here
   --> $DIR/migration_lint.rs:7:9
    |
@@ -33,7 +35,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/migration_lint.rs:30:9
    |
 LL |     let Foo(mut x) = &mut Foo(0);
-   |         ^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^---------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut Foo(mut x) = &mut Foo(0);
@@ -51,7 +55,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:35:9
    |
 LL |     let Foo(ref x) = &Foo(0);
-   |         ^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^---------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &Foo(ref x) = &Foo(0);
@@ -69,7 +75,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/migration_lint.rs:40:9
    |
 LL |     let Foo(ref x) = &mut Foo(0);
-   |         ^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^---------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut Foo(ref x) = &mut Foo(0);
@@ -87,7 +95,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:57:9
    |
 LL |     let Foo(&x) = &Foo(&0);
-   |         ^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &Foo(&x) = &Foo(&0);
@@ -105,7 +115,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:62:9
    |
 LL |     let Foo(&mut x) = &Foo(&mut 0);
-   |         ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &Foo(&mut x) = &Foo(&mut 0);
@@ -123,7 +135,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/migration_lint.rs:67:9
    |
 LL |     let Foo(&x) = &mut Foo(&0);
-   |         ^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut Foo(&x) = &mut Foo(&0);
@@ -141,7 +155,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/migration_lint.rs:72:9
    |
 LL |     let Foo(&mut x) = &mut Foo(&mut 0);
-   |         ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^----------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &mut Foo(&mut x) = &mut Foo(&mut 0);
@@ -159,7 +175,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:81:12
    |
 LL |     if let Some(&x) = &&&&&Some(&0u8) {
-   |            ^^^^^^^^ the default binding mode is `ref`, introduced here
+   |            ^-------
+   |            |
+   |            the default binding mode is `ref`, introduced here
 help: make the implied reference patterns explicit
    |
 LL |     if let &&&&&Some(&x) = &&&&&Some(&0u8) {
@@ -177,7 +195,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:87:12
    |
 LL |     if let Some(&mut x) = &&&&&Some(&mut 0u8) {
-   |            ^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |            ^-----------
+   |            |
+   |            the default binding mode is `ref`, introduced here
 help: make the implied reference patterns explicit
    |
 LL |     if let &&&&&Some(&mut x) = &&&&&Some(&mut 0u8) {
@@ -195,7 +215,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:93:12
    |
 LL |     if let Some(&x) = &&&&&mut Some(&0u8) {
-   |            ^^^^^^^^ the default binding mode is `ref`, introduced here
+   |            ^-------
+   |            |
+   |            the default binding mode is `ref`, introduced here
 help: make the implied reference patterns explicit
    |
 LL |     if let &&&&&mut Some(&x) = &&&&&mut Some(&0u8) {
@@ -213,7 +235,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
   --> $DIR/migration_lint.rs:99:12
    |
 LL |     if let Some(&mut Some(Some(x))) = &mut Some(&mut Some(&mut Some(0u8))) {
-   |            ^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |            ^-----------------------
+   |            |
+   |            the default binding mode is `ref mut`, introduced here
 help: make the implied reference patterns and variable binding mode explicit
    |
 LL |     if let &mut Some(&mut Some(&mut Some(ref mut x))) = &mut Some(&mut Some(&mut Some(0u8))) {
@@ -231,7 +255,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:111:9
    |
 LL |     let Struct { a, mut b, c } = &Struct { a: 0, b: 0, c: 0 };
-   |         ^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^---------------------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern and variable binding modes explicit
    |
 LL |     let &Struct { ref a, mut b, ref c } = &Struct { a: 0, b: 0, c: 0 };
@@ -251,7 +277,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:117:9
    |
 LL |     let Struct { a: &a, b, ref c } = &Struct { a: &0, b: &0, c: &0 };
-   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^-------------------------
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern and variable binding mode explicit
    |
 LL |     let &Struct { a: &a, ref b, ref c } = &Struct { a: &0, b: &0, c: &0 };
@@ -271,7 +299,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:124:12
    |
 LL |     if let Struct { a: &Some(a), b: Some(&b), c: Some(c) } =
-   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |            ^----------------------------------------------
+   |            |
+   |            the default binding mode is `ref`, introduced here
 help: make the implied reference patterns and variable binding mode explicit
    |
 LL |     if let &Struct { a: &Some(a), b: &Some(&b), c: &Some(ref c) } =
@@ -290,7 +320,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:137:9
    |
 LL |         (Some(mut x), migration_lint_macros::mixed_edition_pat!(y)) => {
-   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^----------------------------------------------------------
+   |         |
+   |         the default binding mode is `ref`, introduced here
    = note: this error originates in the macro `migration_lint_macros::mixed_edition_pat` (in Nightly builds, run with -Z macro-backtrace for more info)
 help: make the implied reference pattern explicit
    |
@@ -311,12 +343,16 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:145:15
    |
 LL |     let [&mut [ref a]] = &mut [&mut &[0]];
-   |               ^^^^^^^ the default binding mode is `ref`, introduced here
+   |               ^------
+   |               |
+   |               the default binding mode is `ref`, introduced here
 note: the default binding mode changed to `ref mut` because this has type `&mut _`
   --> $DIR/migration_lint.rs:145:9
    |
 LL |     let [&mut [ref a]] = &mut [&mut &[0]];
-   |         ^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
+   |         ^-------------
+   |         |
+   |         the default binding mode is `ref mut`, introduced here
 help: make the implied reference patterns explicit
    |
 LL |     let &mut [&mut &[ref a]] = &mut [&mut &[0]];
@@ -334,7 +370,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
   --> $DIR/migration_lint.rs:150:9
    |
 LL |     let [&(_)] = &[&0];
-   |         ^^^^^^ the default binding mode is `ref`, introduced here
+   |         ^-----
+   |         |
+   |         the default binding mode is `ref`, introduced here
 help: make the implied reference pattern explicit
    |
 LL |     let &[&(_)] = &[&0];
diff --git a/tests/ui/pattern/rfc-3627-match-ergonomics-2024/min_match_ergonomics_fail.stderr b/tests/ui/pattern/rfc-3627-match-ergonomics-2024/min_match_ergonomics_fail.stderr

Original file line number	Diff line number	Diff line change
`@@ -1137,8 +1137,11 @@ impl Subdiagnostic for Rust2024IncompatiblePatSugg {`
`1137`	`1137`	`def_br_mutbl.ref_prefix_str()`
`1138`	`1138`	`);`
`1139`	`1139`	let label_msg = format!("the default binding mode is `{dbm_str}`, introduced here");
`1140`		`- let mut label = MultiSpan::from(span);`
`1141`		`- label.push_span_label(span, label_msg);`
	`1140`	+ // Get a ^---- label with the ^ pointing to where the user would write `&` or `&mut`
	`1141`	`+ let imaginary_ref_span = span.shrink_to_lo();`
	`1142`	`+ let mut label = MultiSpan::from(imaginary_ref_span);`
	`1143`	`+ label.push_span_label(imaginary_ref_span, label_msg);`
	`1144`	`+ label.push_span_label(span, "");`
`1142`	`1145`	`diag.span_note(label, note_msg);`
`1143`	`1146`	`}`
`1144`	`1147`	`}`
Original file line number	Diff line number	Diff line change
@@ -21,7 +21,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`21`	`21`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:67:9`
`22`	`22`	`\|`
`23`	`23`	`LL \| let [ref mut x] = &[0];`
`24`		- \| ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`24`	`+ \| ^----------`
	`25`	`+ \| \|`
	`26`	+ \| the default binding mode is `ref`, introduced here
`25`	`27`	`help: make the implied reference pattern explicit`
`26`	`28`	`\|`
`27`	`29`	`LL \| let &[ref mut x] = &[0];`
@@ -44,7 +46,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`44`	`46`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:75:9`
`45`	`47`	`\|`
`46`	`48`	`LL \| let [ref x] = &[0];`
`47`		- \| ^^^^^^^ the default binding mode is `ref`, introduced here
	`49`	`+ \| ^------`
	`50`	`+ \| \|`
	`51`	+ \| the default binding mode is `ref`, introduced here
`48`	`52`	`help: make the implied reference pattern explicit`
`49`	`53`	`\|`
`50`	`54`	`LL \| let &[ref x] = &[0];`
@@ -61,7 +65,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`61`	`65`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:79:9`
`62`	`66`	`\|`
`63`	`67`	`LL \| let [ref x] = &mut [0];`
`64`		- \| ^^^^^^^ the default binding mode is `ref mut`, introduced here
	`68`	`+ \| ^------`
	`69`	`+ \| \|`
	`70`	+ \| the default binding mode is `ref mut`, introduced here
`65`	`71`	`help: make the implied reference pattern explicit`
`66`	`72`	`\|`
`67`	`73`	`LL \| let &mut [ref x] = &mut [0];`
@@ -78,7 +84,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`78`	`84`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:83:9`
`79`	`85`	`\|`
`80`	`86`	`LL \| let [ref mut x] = &mut [0];`
`81`		- \| ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`87`	`+ \| ^----------`
	`88`	`+ \| \|`
	`89`	+ \| the default binding mode is `ref mut`, introduced here
`82`	`90`	`help: make the implied reference pattern explicit`
`83`	`91`	`\|`
`84`	`92`	`LL \| let &mut [ref mut x] = &mut [0];`
Original file line number	Diff line number	Diff line change
@@ -9,7 +9,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`9`	`9`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:15:9`
`10`	`10`	`\|`
`11`	`11`	`LL \| let [&ref x] = &[&0];`
`12`		- \| ^^^^^^^^ the default binding mode is `ref`, introduced here
	`12`	`+ \| ^-------`
	`13`	`+ \| \|`
	`14`	+ \| the default binding mode is `ref`, introduced here
`13`	`15`	`help: make the implied reference pattern explicit`
`14`	`16`	`\|`
`15`	`17`	`LL \| let &[&ref x] = &[&0];`
@@ -26,7 +28,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`26`	`28`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:20:9`
`27`	`29`	`\|`
`28`	`30`	`LL \| let [&ref x] = &mut [&0];`
`29`		- \| ^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`31`	`+ \| ^-------`
	`32`	`+ \| \|`
	`33`	+ \| the default binding mode is `ref mut`, introduced here
`30`	`34`	`help: make the implied reference pattern explicit`
`31`	`35`	`\|`
`32`	`36`	`LL \| let &mut [&ref x] = &mut [&0];`
@@ -43,7 +47,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`43`	`47`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:25:9`
`44`	`48`	`\|`
`45`	`49`	`LL \| let [&mut ref x] = &mut [&mut 0];`
`46`		- \| ^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`50`	`+ \| ^-----------`
	`51`	`+ \| \|`
	`52`	+ \| the default binding mode is `ref mut`, introduced here
`47`	`53`	`help: make the implied reference pattern explicit`
`48`	`54`	`\|`
`49`	`55`	`LL \| let &mut [&mut ref x] = &mut [&mut 0];`
@@ -60,7 +66,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`60`	`66`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:30:9`
`61`	`67`	`\|`
`62`	`68`	`LL \| let [&mut ref mut x] = &mut [&mut 0];`
`63`		- \| ^^^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`69`	`+ \| ^---------------`
	`70`	`+ \| \|`
	`71`	+ \| the default binding mode is `ref mut`, introduced here
`64`	`72`	`help: make the implied reference pattern explicit`
`65`	`73`	`\|`
`66`	`74`	`LL \| let &mut [&mut ref mut x] = &mut [&mut 0];`
@@ -77,7 +85,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`77`	`85`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:39:9`
`78`	`86`	`\|`
`79`	`87`	`LL \| let [&ref x] = &[&mut 0];`
`80`		- \| ^^^^^^^^ the default binding mode is `ref`, introduced here
	`88`	`+ \| ^-------`
	`89`	`+ \| \|`
	`90`	+ \| the default binding mode is `ref`, introduced here
`81`	`91`	`help: make the implied reference pattern explicit`
`82`	`92`	`\|`
`83`	`93`	`LL \| let &[&ref x] = &[&mut 0];`
@@ -94,7 +104,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`94`	`104`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:45:9`
`95`	`105`	`\|`
`96`	`106`	`LL \| let [&ref x] = &mut [&mut 0];`
`97`		- \| ^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`107`	`+ \| ^-------`
	`108`	`+ \| \|`
	`109`	+ \| the default binding mode is `ref mut`, introduced here
`98`	`110`	`help: make the implied reference pattern explicit`
`99`	`111`	`\|`
`100`	`112`	`LL \| let &mut [&ref x] = &mut [&mut 0];`
@@ -111,7 +123,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`111`	`123`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:54:9`
`112`	`124`	`\|`
`113`	`125`	`LL \| let [&mut ref x] = &[&mut 0];`
`114`		- \| ^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`126`	`+ \| ^-----------`
	`127`	`+ \| \|`
	`128`	+ \| the default binding mode is `ref`, introduced here
`115`	`129`	`help: make the implied reference pattern explicit`
`116`	`130`	`\|`
`117`	`131`	`LL \| let &[&mut ref x] = &[&mut 0];`
@@ -128,7 +142,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`128`	`142`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:67:9`
`129`	`143`	`\|`
`130`	`144`	`LL \| let [ref mut x] = &[0];`
`131`		- \| ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`145`	`+ \| ^----------`
	`146`	`+ \| \|`
	`147`	+ \| the default binding mode is `ref`, introduced here
`132`	`148`	`help: make the implied reference pattern explicit`
`133`	`149`	`\|`
`134`	`150`	`LL \| let &[ref mut x] = &[0];`
@@ -151,7 +167,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`151`	`167`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:75:9`
`152`	`168`	`\|`
`153`	`169`	`LL \| let [ref x] = &[0];`
`154`		- \| ^^^^^^^ the default binding mode is `ref`, introduced here
	`170`	`+ \| ^------`
	`171`	`+ \| \|`
	`172`	+ \| the default binding mode is `ref`, introduced here
`155`	`173`	`help: make the implied reference pattern explicit`
`156`	`174`	`\|`
`157`	`175`	`LL \| let &[ref x] = &[0];`
@@ -168,7 +186,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`168`	`186`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:79:9`
`169`	`187`	`\|`
`170`	`188`	`LL \| let [ref x] = &mut [0];`
`171`		- \| ^^^^^^^ the default binding mode is `ref mut`, introduced here
	`189`	`+ \| ^------`
	`190`	`+ \| \|`
	`191`	+ \| the default binding mode is `ref mut`, introduced here
`172`	`192`	`help: make the implied reference pattern explicit`
`173`	`193`	`\|`
`174`	`194`	`LL \| let &mut [ref x] = &mut [0];`
@@ -185,7 +205,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`185`	`205`	`--> $DIR/ref-binding-on-inh-ref-errors.rs:83:9`
`186`	`206`	`\|`
`187`	`207`	`LL \| let [ref mut x] = &mut [0];`
`188`		- \| ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`208`	`+ \| ^----------`
	`209`	`+ \| \|`
	`210`	+ \| the default binding mode is `ref mut`, introduced here
`189`	`211`	`help: make the implied reference pattern explicit`
`190`	`212`	`\|`
`191`	`213`	`LL \| let &mut [ref mut x] = &mut [0];`
Original file line number	Diff line number	Diff line change
@@ -10,7 +10,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`10`	`10`	`--> $DIR/migration_lint.rs:25:9`
`11`	`11`	`\|`
`12`	`12`	`LL \| let Foo(mut x) = &Foo(0);`
`13`		- \| ^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`13`	`+ \| ^---------`
	`14`	`+ \| \|`
	`15`	+ \| the default binding mode is `ref`, introduced here
`14`	`16`	`note: the lint level is defined here`
`15`	`17`	`--> $DIR/migration_lint.rs:7:9`
`16`	`18`	`\|`
@@ -33,7 +35,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`33`	`35`	`--> $DIR/migration_lint.rs:30:9`
`34`	`36`	`\|`
`35`	`37`	`LL \| let Foo(mut x) = &mut Foo(0);`
`36`		- \| ^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`38`	`+ \| ^---------`
	`39`	`+ \| \|`
	`40`	+ \| the default binding mode is `ref mut`, introduced here
`37`	`41`	`help: make the implied reference pattern explicit`
`38`	`42`	`\|`
`39`	`43`	`LL \| let &mut Foo(mut x) = &mut Foo(0);`
@@ -51,7 +55,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`51`	`55`	`--> $DIR/migration_lint.rs:35:9`
`52`	`56`	`\|`
`53`	`57`	`LL \| let Foo(ref x) = &Foo(0);`
`54`		- \| ^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`58`	`+ \| ^---------`
	`59`	`+ \| \|`
	`60`	+ \| the default binding mode is `ref`, introduced here
`55`	`61`	`help: make the implied reference pattern explicit`
`56`	`62`	`\|`
`57`	`63`	`LL \| let &Foo(ref x) = &Foo(0);`
@@ -69,7 +75,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`69`	`75`	`--> $DIR/migration_lint.rs:40:9`
`70`	`76`	`\|`
`71`	`77`	`LL \| let Foo(ref x) = &mut Foo(0);`
`72`		- \| ^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`78`	`+ \| ^---------`
	`79`	`+ \| \|`
	`80`	+ \| the default binding mode is `ref mut`, introduced here
`73`	`81`	`help: make the implied reference pattern explicit`
`74`	`82`	`\|`
`75`	`83`	`LL \| let &mut Foo(ref x) = &mut Foo(0);`
@@ -87,7 +95,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`87`	`95`	`--> $DIR/migration_lint.rs:57:9`
`88`	`96`	`\|`
`89`	`97`	`LL \| let Foo(&x) = &Foo(&0);`
`90`		- \| ^^^^^^^ the default binding mode is `ref`, introduced here
	`98`	`+ \| ^------`
	`99`	`+ \| \|`
	`100`	+ \| the default binding mode is `ref`, introduced here
`91`	`101`	`help: make the implied reference pattern explicit`
`92`	`102`	`\|`
`93`	`103`	`LL \| let &Foo(&x) = &Foo(&0);`
@@ -105,7 +115,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`105`	`115`	`--> $DIR/migration_lint.rs:62:9`
`106`	`116`	`\|`
`107`	`117`	`LL \| let Foo(&mut x) = &Foo(&mut 0);`
`108`		- \| ^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`118`	`+ \| ^----------`
	`119`	`+ \| \|`
	`120`	+ \| the default binding mode is `ref`, introduced here
`109`	`121`	`help: make the implied reference pattern explicit`
`110`	`122`	`\|`
`111`	`123`	`LL \| let &Foo(&mut x) = &Foo(&mut 0);`
@@ -123,7 +135,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`123`	`135`	`--> $DIR/migration_lint.rs:67:9`
`124`	`136`	`\|`
`125`	`137`	`LL \| let Foo(&x) = &mut Foo(&0);`
`126`		- \| ^^^^^^^ the default binding mode is `ref mut`, introduced here
	`138`	`+ \| ^------`
	`139`	`+ \| \|`
	`140`	+ \| the default binding mode is `ref mut`, introduced here
`127`	`141`	`help: make the implied reference pattern explicit`
`128`	`142`	`\|`
`129`	`143`	`LL \| let &mut Foo(&x) = &mut Foo(&0);`
@@ -141,7 +155,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`141`	`155`	`--> $DIR/migration_lint.rs:72:9`
`142`	`156`	`\|`
`143`	`157`	`LL \| let Foo(&mut x) = &mut Foo(&mut 0);`
`144`		- \| ^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`158`	`+ \| ^----------`
	`159`	`+ \| \|`
	`160`	+ \| the default binding mode is `ref mut`, introduced here
`145`	`161`	`help: make the implied reference pattern explicit`
`146`	`162`	`\|`
`147`	`163`	`LL \| let &mut Foo(&mut x) = &mut Foo(&mut 0);`
@@ -159,7 +175,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`159`	`175`	`--> $DIR/migration_lint.rs:81:12`
`160`	`176`	`\|`
`161`	`177`	`LL \| if let Some(&x) = &&&&&Some(&0u8) {`
`162`		- \| ^^^^^^^^ the default binding mode is `ref`, introduced here
	`178`	`+ \| ^-------`
	`179`	`+ \| \|`
	`180`	+ \| the default binding mode is `ref`, introduced here
`163`	`181`	`help: make the implied reference patterns explicit`
`164`	`182`	`\|`
`165`	`183`	`LL \| if let &&&&&Some(&x) = &&&&&Some(&0u8) {`
@@ -177,7 +195,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`177`	`195`	`--> $DIR/migration_lint.rs:87:12`
`178`	`196`	`\|`
`179`	`197`	`LL \| if let Some(&mut x) = &&&&&Some(&mut 0u8) {`
`180`		- \| ^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`198`	`+ \| ^-----------`
	`199`	`+ \| \|`
	`200`	+ \| the default binding mode is `ref`, introduced here
`181`	`201`	`help: make the implied reference patterns explicit`
`182`	`202`	`\|`
`183`	`203`	`LL \| if let &&&&&Some(&mut x) = &&&&&Some(&mut 0u8) {`
@@ -195,7 +215,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`195`	`215`	`--> $DIR/migration_lint.rs:93:12`
`196`	`216`	`\|`
`197`	`217`	`LL \| if let Some(&x) = &&&&&mut Some(&0u8) {`
`198`		- \| ^^^^^^^^ the default binding mode is `ref`, introduced here
	`218`	`+ \| ^-------`
	`219`	`+ \| \|`
	`220`	+ \| the default binding mode is `ref`, introduced here
`199`	`221`	`help: make the implied reference patterns explicit`
`200`	`222`	`\|`
`201`	`223`	`LL \| if let &&&&&mut Some(&x) = &&&&&mut Some(&0u8) {`
@@ -213,7 +235,9 @@ note: the default binding mode changed to `ref mut` because this has type `&mut
`213`	`235`	`--> $DIR/migration_lint.rs:99:12`
`214`	`236`	`\|`
`215`	`237`	`LL \| if let Some(&mut Some(Some(x))) = &mut Some(&mut Some(&mut Some(0u8))) {`
`216`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`238`	`+ \| ^-----------------------`
	`239`	`+ \| \|`
	`240`	+ \| the default binding mode is `ref mut`, introduced here
`217`	`241`	`help: make the implied reference patterns and variable binding mode explicit`
`218`	`242`	`\|`
`219`	`243`	`LL \| if let &mut Some(&mut Some(&mut Some(ref mut x))) = &mut Some(&mut Some(&mut Some(0u8))) {`
@@ -231,7 +255,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`231`	`255`	`--> $DIR/migration_lint.rs:111:9`
`232`	`256`	`\|`
`233`	`257`	`LL \| let Struct { a, mut b, c } = &Struct { a: 0, b: 0, c: 0 };`
`234`		- \| ^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`258`	`+ \| ^---------------------`
	`259`	`+ \| \|`
	`260`	+ \| the default binding mode is `ref`, introduced here
`235`	`261`	`help: make the implied reference pattern and variable binding modes explicit`
`236`	`262`	`\|`
`237`	`263`	`LL \| let &Struct { ref a, mut b, ref c } = &Struct { a: 0, b: 0, c: 0 };`
@@ -251,7 +277,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`251`	`277`	`--> $DIR/migration_lint.rs:117:9`
`252`	`278`	`\|`
`253`	`279`	`LL \| let Struct { a: &a, b, ref c } = &Struct { a: &0, b: &0, c: &0 };`
`254`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`280`	`+ \| ^-------------------------`
	`281`	`+ \| \|`
	`282`	+ \| the default binding mode is `ref`, introduced here
`255`	`283`	`help: make the implied reference pattern and variable binding mode explicit`
`256`	`284`	`\|`
`257`	`285`	`LL \| let &Struct { a: &a, ref b, ref c } = &Struct { a: &0, b: &0, c: &0 };`
@@ -271,7 +299,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`271`	`299`	`--> $DIR/migration_lint.rs:124:12`
`272`	`300`	`\|`
`273`	`301`	`LL \| if let Struct { a: &Some(a), b: Some(&b), c: Some(c) } =`
`274`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`302`	`+ \| ^----------------------------------------------`
	`303`	`+ \| \|`
	`304`	+ \| the default binding mode is `ref`, introduced here
`275`	`305`	`help: make the implied reference patterns and variable binding mode explicit`
`276`	`306`	`\|`
`277`	`307`	`LL \| if let &Struct { a: &Some(a), b: &Some(&b), c: &Some(ref c) } =`
@@ -290,7 +320,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`290`	`320`	`--> $DIR/migration_lint.rs:137:9`
`291`	`321`	`\|`
`292`	`322`	`LL \| (Some(mut x), migration_lint_macros::mixed_edition_pat!(y)) => {`
`293`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the default binding mode is `ref`, introduced here
	`323`	`+ \| ^----------------------------------------------------------`
	`324`	`+ \| \|`
	`325`	+ \| the default binding mode is `ref`, introduced here
`294`	`326`	= note: this error originates in the macro `migration_lint_macros::mixed_edition_pat` (in Nightly builds, run with -Z macro-backtrace for more info)
`295`	`327`	`help: make the implied reference pattern explicit`
`296`	`328`	`\|`
@@ -311,12 +343,16 @@ note: the default binding mode changed to `ref` because this has type `&_`
`311`	`343`	`--> $DIR/migration_lint.rs:145:15`
`312`	`344`	`\|`
`313`	`345`	`LL \| let [&mut [ref a]] = &mut [&mut &[0]];`
`314`		- \| ^^^^^^^ the default binding mode is `ref`, introduced here
	`346`	`+ \| ^------`
	`347`	`+ \| \|`
	`348`	+ \| the default binding mode is `ref`, introduced here
`315`	`349`	note: the default binding mode changed to `ref mut` because this has type `&mut _`
`316`	`350`	`--> $DIR/migration_lint.rs:145:9`
`317`	`351`	`\|`
`318`	`352`	`LL \| let [&mut [ref a]] = &mut [&mut &[0]];`
`319`		- \| ^^^^^^^^^^^^^^ the default binding mode is `ref mut`, introduced here
	`353`	`+ \| ^-------------`
	`354`	`+ \| \|`
	`355`	+ \| the default binding mode is `ref mut`, introduced here
`320`	`356`	`help: make the implied reference patterns explicit`
`321`	`357`	`\|`
`322`	`358`	`LL \| let &mut [&mut &[ref a]] = &mut [&mut &[0]];`
@@ -334,7 +370,9 @@ note: the default binding mode changed to `ref` because this has type `&_`
`334`	`370`	`--> $DIR/migration_lint.rs:150:9`
`335`	`371`	`\|`
`336`	`372`	`LL \| let [&(_)] = &[&0];`
`337`		- \| ^^^^^^ the default binding mode is `ref`, introduced here
	`373`	`+ \| ^-----`
	`374`	`+ \| \|`
	`375`	+ \| the default binding mode is `ref`, introduced here
`338`	`376`	`help: make the implied reference pattern explicit`
`339`	`377`	`\|`
`340`	`378`	`LL \| let &[&(_)] = &[&0];`