add FIXME for bivariant lub/glb

nikomatsakis · nikomatsakis · commit 77d9e38e9499 · 2017-04-11T20:32:47.000-04:00
diff --git a/src/librustc/infer/glb.rs b/src/librustc/infer/glb.rs
@@ -49,6 +49,7 @@ impl<'combine, 'infcx, 'gcx, 'tcx> TypeRelation<'infcx, 'gcx, 'tcx>
         match variance {
             ty::Invariant => self.fields.equate(self.a_is_expected).relate(a, b),
             ty::Covariant => self.relate(a, b),
+            // FIXME(#41044) -- not correct, need test
             ty::Bivariant => Ok(a.clone()),
             ty::Contravariant => self.fields.lub(self.a_is_expected).relate(a, b),
         }
diff --git a/src/librustc/infer/lub.rs b/src/librustc/infer/lub.rs
@@ -49,6 +49,7 @@ impl<'combine, 'infcx, 'gcx, 'tcx> TypeRelation<'infcx, 'gcx, 'tcx>
         match variance {
             ty::Invariant => self.fields.equate(self.a_is_expected).relate(a, b),
             ty::Covariant => self.relate(a, b),
+            // FIXME(#41044) -- not correct, need test
             ty::Bivariant => Ok(a.clone()),
             ty::Contravariant => self.fields.glb(self.a_is_expected).relate(a, b),
         }

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ impl<'combine, 'infcx, 'gcx, 'tcx> TypeRelation<'infcx, 'gcx, 'tcx>`
`49`	`49`	`match variance {`
`50`	`50`	`ty::Invariant => self.fields.equate(self.a_is_expected).relate(a, b),`
`51`	`51`	`ty::Covariant => self.relate(a, b),`
	`52`	`+ // FIXME(#41044) -- not correct, need test`
`52`	`53`	`ty::Bivariant => Ok(a.clone()),`
`53`	`54`	`ty::Contravariant => self.fields.lub(self.a_is_expected).relate(a, b),`
`54`	`55`	`}`