Improve the error message when resolution of methods/items finds no matching impl.

Author: quantheory

src/librustc_typeck/check/method/mod.rs

@@ -40,7 +40,7 @@ pub enum MethodError {
     // Did not find an applicable method, but we did find various
     // static methods that may apply, as well as a list of
     // not-in-scope traits which may work.
-    NoMatch(Vec<CandidateSource>, Vec<ast::DefId>),
+    NoMatch(Vec<CandidateSource>, Vec<ast::DefId>, probe::Mode),
 
     // Multiple methods might apply.
     Ambiguity(Vec<CandidateSource>),

src/librustc_typeck/check/method/probe.rs

@@ -136,7 +136,7 @@ pub fn probe<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
     let steps = if mode == Mode::MethodCall {
         match create_steps(fcx, span, self_ty) {
             Some(steps) => steps,
-            None => return Err(MethodError::NoMatch(Vec::new(), Vec::new())),
+            None => return Err(MethodError::NoMatch(Vec::new(), Vec::new(), mode)),
         }
     } else {
         vec![CandidateStep {
@@ -866,7 +866,7 @@ impl<'a,'tcx> ProbeContext<'a,'tcx> {
                     }
                 }
             }).collect(),
-            Some(Err(MethodError::NoMatch(_, others))) => {
+            Some(Err(MethodError::NoMatch(_, others, _))) => {
                 assert!(others.is_empty());
                 vec![]
             }
@@ -877,7 +877,7 @@ impl<'a,'tcx> ProbeContext<'a,'tcx> {
             None => vec![],
         };
 
-        Err(MethodError::NoMatch(static_candidates, out_of_scope_traits))
+        Err(MethodError::NoMatch(static_candidates, out_of_scope_traits, self.mode))
     }
 
     fn pick_core(&mut self) -> Option<PickResult<'tcx>> {

src/librustc_typeck/check/method/suggest.rs

@@ -28,6 +28,7 @@ use std::cell;
 use std::cmp::Ordering;
 
 use super::{MethodError, CandidateSource, impl_item, trait_item};
+use super::probe::Mode;
 
 pub fn report_error<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
                               span: Span,
@@ -42,17 +43,19 @@ pub fn report_error<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
     }
 
     match error {
-        MethodError::NoMatch(static_sources, out_of_scope_traits) => {
+        MethodError::NoMatch(static_sources, out_of_scope_traits, mode) => {
             let cx = fcx.tcx();
             let item_ustring = item_name.user_string(cx);
 
             fcx.type_error_message(
                 span,
                 |actual| {
-                    format!("type `{}` does not implement any \
-                             item in scope named `{}`",
-                            actual,
-                            item_ustring)
+                    format!("no {} named `{}` found for type `{}` \
+                             in the current scope",
+                            if mode == Mode::MethodCall { "method" }
+                            else { "associated item" },
+                            item_ustring,
+                            actual)
                 },
                 rcvr_ty,
                 None);

src/test/compile-fail/auto-ref-slice-plus-ref.rs

@@ -15,11 +15,11 @@ fn main() {
     // vectors to slices then automatically create a self reference.
 
     let mut a = vec!(0);
-    a.test_mut(); //~ ERROR does not implement any item in scope named `test_mut`
-    a.test(); //~ ERROR does not implement any item in scope named `test`
+    a.test_mut(); //~ ERROR no method named `test_mut` found
+    a.test(); //~ ERROR no method named `test` found
 
-    ([1]).test(); //~ ERROR does not implement any item in scope named `test`
-    (&[1]).test(); //~ ERROR does not implement any item in scope named `test`
+    ([1]).test(); //~ ERROR no method named `test` found
+    (&[1]).test(); //~ ERROR no method named `test` found
 }
 
 trait MyIter {

src/test/compile-fail/class-cast-to-trait.rs

@@ -60,5 +60,5 @@ fn cat(in_x : usize, in_y : isize, in_name: String) -> cat {
 
 fn main() {
   let nyan: Box<noisy> = box cat(0, 2, "nyan".to_string()) as Box<noisy>;
-  nyan.eat(); //~ ERROR does not implement any item in scope named `eat`
+  nyan.eat(); //~ ERROR no method named `eat` found
 }

src/test/compile-fail/coherence_inherent.rs

@@ -38,7 +38,7 @@ mod NoImport {
     use Lib::TheStruct;
 
     fn call_the_fn(s: &TheStruct) {
-        s.the_fn(); //~ ERROR does not implement any item in scope named `the_fn`
+        s.the_fn(); //~ ERROR no method named `the_fn` found
     }
 }
 

src/test/compile-fail/coherence_inherent_cc.rs

@@ -30,7 +30,7 @@ mod NoImport {
     use coherence_inherent_cc_lib::TheStruct;
 
     fn call_the_fn(s: &TheStruct) {
-        s.the_fn(); //~ ERROR does not implement any item in scope named `the_fn`
+        s.the_fn(); //~ ERROR no method named `the_fn` found
     }
 }
 

src/test/compile-fail/copy-a-resource.rs

@@ -26,6 +26,6 @@ fn foo(i:isize) -> foo {
 fn main() {
     let x = foo(10);
     let _y = x.clone();
-    //~^ ERROR does not implement any item in scope
+    //~^ ERROR no method named `clone` found
     println!("{:?}", x);
 }

src/test/compile-fail/issue-10465.rs

@@ -24,7 +24,7 @@ pub mod b {
         use b::B;
 
         fn foo(b: &B) {
-            b.foo(); //~ ERROR: does not implement any item in scope named
+            b.foo(); //~ ERROR: no method named `foo` found
         }
     }
 

src/test/compile-fail/issue-13853.rs

@@ -31,7 +31,7 @@ impl Node for Stuff {
 }
 
 fn iterate<N: Node, G: Graph<N>>(graph: &G) {
-    for node in graph.iter() { //~ ERROR does not implement any item in scope named
+    for node in graph.iter() { //~ ERROR no method named `iter` found
         node.zomg();  //~ error: the type of this value must be known in this context
     }
 }

src/test/compile-fail/issue-18343.rs

@@ -14,6 +14,6 @@ struct Obj<F> where F: FnMut() -> u32 {
 
 fn main() {
     let o = Obj { closure: || 42 };
-    o.closure(); //~ ERROR does not implement any item in scope named `closure`
+    o.closure(); //~ ERROR no method named `closure` found
     //~^ NOTE use `(s.closure)(...)` if you meant to call the function stored in the `closure` field
 }

src/test/compile-fail/issue-1871.rs

@@ -14,7 +14,7 @@ fn main() {
   let f = 42;
 
   let _g = if f < 5 {
-      f.honk() //~ ERROR does not implement any item in scope named `honk`
+      f.honk() //~ ERROR no method named `honk` found
   }
   else {
       ()

src/test/compile-fail/issue-19521.rs

@@ -11,5 +11,5 @@
 #![feature(unboxed_closures)]
 
 fn main() {
-    "".homura()(); //~ ERROR does not implement any item
+    "".homura()(); //~ ERROR no method named `homura` found
 }

src/test/compile-fail/issue-19692.rs

@@ -11,7 +11,7 @@
 struct Homura;
 
 fn akemi(homura: Homura) {
-    let Some(ref madoka) = Some(homura.kaname()); //~ ERROR does not implement any item
+    let Some(ref madoka) = Some(homura.kaname()); //~ ERROR no method named `kaname` found
     madoka.clone();
 }
 

src/test/compile-fail/issue-2149.rs

@@ -22,5 +22,5 @@ impl<A> vec_monad<A> for Vec<A> {
 }
 fn main() {
     ["hi"].bind(|x| [x] );
-    //~^ ERROR type `[&str; 1]` does not implement any item in scope named `bind`
+    //~^ ERROR no method named `bind` found for type `[&str; 1]` in the current scope
 }

src/test/compile-fail/issue-2823.rs

@@ -20,5 +20,5 @@ impl Drop for C {
 
 fn main() {
     let c = C{ x: 2};
-    let _d = c.clone(); //~ ERROR does not implement any item in scope
+    let _d = c.clone(); //~ ERROR no method named `clone` found
 }

src/test/compile-fail/issue-3563.rs

@@ -11,7 +11,7 @@
 trait A {
     fn a(&self) {
         || self.b()
-        //~^ ERROR type `&Self` does not implement any item in scope named `b`
+        //~^ ERROR no method named `b` found for type `&Self` in the current scope
         //~| ERROR mismatched types
         //~| expected `()`
         //~| found closure

src/test/compile-fail/issue-3707.rs

@@ -17,7 +17,7 @@ impl Obj {
         return 1+1 == 2
     }
     pub fn chirp(&self) {
-        self.boom(); //~ ERROR `&Obj` does not implement any item in scope named `boom`
+        self.boom(); //~ ERROR no method named `boom` found for type `&Obj` in the current scope
     }
 }
 

src/test/compile-fail/issue-5153.rs

@@ -8,8 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// error-pattern: type `&Foo` does not implement any item in scope named `foo`
-
 trait Foo {
     fn foo(self: Box<Self>);
 }
@@ -20,4 +18,5 @@ impl Foo for isize {
 
 fn main() {
     (&5 as &Foo).foo();
+    //~^ ERROR: no method named `foo` found for type `&Foo` in the current scope
 }

src/test/compile-fail/issue-7575.rs

@@ -71,15 +71,15 @@ impl ManyImplTrait for Myisize {}
 
 fn no_param_bound(u: usize, m: Myisize) -> usize {
     u.f8(42) + u.f9(342) + m.fff(42)
-            //~^ ERROR type `usize` does not implement any item in scope named `f9`
+            //~^ ERROR no method named `f9` found for type `usize` in the current scope
             //~^^ NOTE found defined static methods, maybe a `self` is missing?
-            //~^^^ ERROR type `Myisize` does not implement any item in scope named `fff`
+            //~^^^ ERROR no method named `fff` found for type `Myisize` in the current scope
             //~^^^^ NOTE found defined static methods, maybe a `self` is missing?
 }
 
 fn param_bound<T: ManyImplTrait>(t: T) -> bool {
     t.is_str()
-    //~^ ERROR type `T` does not implement any item in scope named `is_str`
+    //~^ ERROR no method named `is_str` found for type `T` in the current scope
     //~^^ NOTE found defined static methods, maybe a `self` is missing?
 }
 

src/test/compile-fail/issue-7950.rs

@@ -13,5 +13,5 @@
 struct Foo;
 
 fn main() {
-    Foo::bar(); //~ ERROR type `Foo` does not implement any item in scope named `bar`
+    Foo::bar(); //~ ERROR no associated item named `bar` found for type `Foo` in the current scope
 }

src/test/compile-fail/macro-backtrace-invalid-internals.rs

@@ -12,7 +12,7 @@
 
 macro_rules! fake_method_stmt { //~ NOTE in expansion of
      () => {
-          1.fake() //~ ERROR does not implement any item
+          1.fake() //~ ERROR no method named `fake` found
      }
 }
 
@@ -30,7 +30,7 @@ macro_rules! fake_anon_field_stmt { //~ NOTE in expansion of
 
 macro_rules! fake_method_expr { //~ NOTE in expansion of
      () => {
-          1.fake() //~ ERROR does not implement any item
+          1.fake() //~ ERROR no method named `fake` found
      }
 }
 

src/test/compile-fail/method-call-err-msg.rs

@@ -25,6 +25,6 @@ fn main() {
 
     let y = Foo;
     y.zero()
-     .take()    //~ ERROR type `Foo` does not implement any item in scope named `take`
+     .take()    //~ ERROR no method named `take` found for type `Foo` in the current scope
      .one(0);
 }

src/test/compile-fail/method-suggestion-no-duplication.rs

@@ -16,7 +16,7 @@ fn foo<F>(f: F) where F: FnMut(Foo) {}
 
 fn main() {
     foo(|s| s.is_empty());
-    //~^ ERROR does not implement any item
+    //~^ ERROR no method named `is_empty` found
     //~^^ HELP #1: `core::slice::SliceExt`
     //~^^^ HELP #2: `core::str::StrExt`
 }