Skip to content

Commit 68df650

Browse files
committed
Give an item related to issue 27438 a more meaningful name
1 parent 7486176 commit 68df650

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

compiler/rustc_data_structures/src/lib.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ pub fn make_display(f: impl Fn(&mut fmt::Formatter<'_>) -> fmt::Result) -> impl
146146
Printer { f }
147147
}
148148

149-
// See comments in compiler/rustc_middle/src/tests.rs
149+
// See comment in compiler/rustc_middle/src/tests.rs and issue #27438.
150150
#[doc(hidden)]
151-
pub fn __noop_fix_for_27438() {}
151+
pub fn __noop_fix_for_windows_dllimport_issue() {}
152152

153153
#[macro_export]
154154
macro_rules! external_bitflags_debug {

compiler/rustc_middle/src/tests.rs

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
use super::*;
22

3-
// FIXME(#27438): right now the unit tests of rustc_middle don't refer to any actual
4-
// functions generated in rustc_data_structures (all
5-
// references are through generic functions), but statics are
6-
// referenced from time to time. Due to this bug we won't
7-
// actually correctly link in the statics unless we also
8-
// reference a function, so be sure to reference a dummy
9-
// function.
3+
// FIXME(#27438): Right now, the unit tests of `rustc_middle` don't refer to any actual functions
4+
// generated in `rustc_data_structures` (all references are through generic functions),
5+
// but statics are referenced from time to time. Due to this Windows `dllimport` bug
6+
// we won't actually correctly link in the statics unless we also reference a function,
7+
// so be sure to reference a dummy function.
108
#[test]
119
fn noop() {
12-
rustc_data_structures::__noop_fix_for_27438();
10+
rustc_data_structures::__noop_fix_for_windows_dllimport_issue();
1311
}

0 commit comments

Comments
 (0)