rustc_macros: Reduce scope of span in from_attr()

Enselic · Enselic · commit 5c25ff52f6f0 · 2023-12-15T23:04:26.000+01:00
diff --git a/compiler/rustc_macros/src/diagnostics/utils.rs b/compiler/rustc_macros/src/diagnostics/utils.rs
@@ -616,8 +616,6 @@ impl SubdiagnosticVariant {
             return Ok(None);
         }
 
-        let span = attr.span().unwrap();
-
         let name = attr.path().segments.last().unwrap().ident.to_string();
         let name = name.as_str();
 
@@ -667,6 +665,8 @@ impl SubdiagnosticVariant {
             }
         };
 
+        let span = attr.span().unwrap();
+
         let list = match &attr.meta {
             Meta::List(list) => {
                 // An attribute with properties, such as `#[suggestion(code = "...")]` or

Original file line number	Diff line number	Diff line change
`@@ -616,8 +616,6 @@ impl SubdiagnosticVariant {`
`616`	`616`	`return Ok(None);`
`617`	`617`	`}`
`618`	`618`
`619`		`- let span = attr.span().unwrap();`
`620`		`-`
`621`	`619`	`let name = attr.path().segments.last().unwrap().ident.to_string();`
`622`	`620`	`let name = name.as_str();`
`623`	`621`
`@@ -667,6 +665,8 @@ impl SubdiagnosticVariant {`
`667`	`665`	`}`
`668`	`666`	`};`
`669`	`667`
	`668`	`+ let span = attr.span().unwrap();`
	`669`	`+`
`670`	`670`	`let list = match &attr.meta {`
`671`	`671`	`Meta::List(list) => {`
`672`	`672`	// An attribute with properties, such as `#[suggestion(code = "...")]` or