Skip to content

Commit 5bd4e27

Browse files
committed
FIN: update appveyor mingw description
1 parent 5ae4a58 commit 5bd4e27

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

appveyor.yml

+5-16
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,17 @@ environment:
2020

2121
# 32/64-bit MinGW builds.
2222
#
23-
# The MinGW builds unfortunately have to both download a custom toolchain and
24-
# avoid the one installed by AppVeyor by default. Interestingly, though, for
25-
# different reasons!
23+
# We are using MinGW with posix threads since LLVM does not compile with
24+
# the win32 threads version due to missing support for C++'s std::thread.
2625
#
27-
# For 32-bit the installed gcc toolchain on AppVeyor uses the pthread
28-
# threading model. This is unfortunately not what we want, and if we compile
29-
# with it then there's lots of link errors in the standard library (undefined
30-
# references to pthread symbols).
31-
#
32-
# For 64-bit the installed gcc toolchain is currently 5.3.0 which
33-
# unfortunately segfaults on Windows with --enable-llvm-assertions (segfaults
34-
# in LLVM). See rust-lang/rust#28445 for more information, but to work around
35-
# this we go back in time to 4.9.2 specifically.
26+
# Instead of relying on the MinGW version installed on appveryor we download
27+
# and install one ourselves so we won't be surprised by changes to appveyor's
28+
# build image.
3629
#
3730
# Finally, note that the downloads below are all in the `rust-lang-ci` S3
3831
# bucket, but they cleraly didn't originate there! The downloads originally
3932
# came from the mingw-w64 SourceForge download site. Unfortunately
4033
# SourceForge is notoriously flaky, so we mirror it on our own infrastructure.
41-
#
42-
# And as a final point of note, the 32-bit MinGW build using the makefiles do
43-
# *not* use debug assertions and llvm assertions. This is because they take
44-
# too long on appveyor and this is tested by rustbuild below.
4534
- MSYS_BITS: 32
4635
RUST_CONFIGURE_ARGS: --build=i686-pc-windows-gnu --enable-ninja
4736
SCRIPT: python x.py test

0 commit comments

Comments
 (0)