Comment change suggestions from oli-obk's code review

NCGThompson · oli-obk · web-flow · commit 509dc03961b9 · 2024-01-16T10:26:53.000-05:00
Co-authored-by: Oli Scherer &lt;github35764891676564198441@oli-obk.de&gt;
diff --git a/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs b/compiler/rustc_codegen_cranelift/src/intrinsics/mod.rs
@@ -442,7 +442,7 @@ fn codegen_regular_intrinsic_call<'tcx>(
         sym::is_val_statically_known => {
             intrinsic_args!(fx, args => (_a); intrinsic);
 
-            // FIXME impliment intrinsic or guarantee propogation of false
+            // FIXME actually return `true` in case the argument is a constant
             let res = fx.bcx.ins().iconst(cranelift_codegen::ir::types::I8, false as i64);
             ret.write_cvalue(fx, CValue::by_val(res, ret.layout()));
         }

Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ fn codegen_regular_intrinsic_call<'tcx>(`
`442`	`442`	`sym::is_val_statically_known => {`
`443`	`443`	`intrinsic_args!(fx, args => (_a); intrinsic);`
`444`	`444`
`445`		`- // FIXME impliment intrinsic or guarantee propogation of false`
	`445`	+ // FIXME actually return `true` in case the argument is a constant
`446`	`446`	`let res = fx.bcx.ins().iconst(cranelift_codegen::ir::types::I8, false as i64);`
`447`	`447`	`ret.write_cvalue(fx, CValue::by_val(res, ret.layout()));`
`448`	`448`	`}`