Skip to content

Commit 46b0b28

Browse files
committed
Revert "Split x86_64-msvc-ext into two jobs"
This reverts commit 7358429.
1 parent 738e35e commit 46b0b28

File tree

2 files changed

+5
-34
lines changed

2 files changed

+5
-34
lines changed

Diff for: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh

+5-9
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,8 @@ case $HOST_TARGET in
5858
# Strangely, Linux targets do not work here. cargo always says
5959
# "error: cannot produce cdylib for ... as the target ... does not support these crate types".
6060
# Only run "pass" tests, which is quite a bit faster.
61-
#FIXME: Re-enable this once CI issues are fixed
62-
# See <https://github.com/rust-lang/rust/issues/127883>
63-
# For now, these tests are moved to `x86_64-msvc-ext2` in `src/ci/github-actions/jobs.yml`.
64-
#python3 "$X_PY" test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass
65-
#python3 "$X_PY" test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass
61+
python3 "$X_PY" test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass
62+
python3 "$X_PY" test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass
6663
;;
6764
*)
6865
echo "FATAL: unexpected host $HOST_TARGET"
@@ -71,7 +68,6 @@ case $HOST_TARGET in
7168
esac
7269
# Also smoke-test `x.py miri`. This doesn't run any actual tests (that would take too long),
7370
# but it ensures that the crates build properly when tested with Miri.
74-
#FIXME: Re-enable this once CI issues are fixed
75-
#python3 "$X_PY" miri --stage 2 library/core --test-args notest
76-
#python3 "$X_PY" miri --stage 2 library/alloc --test-args notest
77-
#python3 "$X_PY" miri --stage 2 library/std --test-args notest
71+
python3 "$X_PY" miri --stage 2 library/core --test-args notest
72+
python3 "$X_PY" miri --stage 2 library/alloc --test-args notest
73+
python3 "$X_PY" miri --stage 2 library/std --test-args notest

Diff for: src/ci/github-actions/jobs.yml

-25
Original file line numberDiff line numberDiff line change
@@ -435,31 +435,6 @@ auto:
435435
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
436436
<<: *job-windows
437437

438-
# Temporary builder to workaround CI issues
439-
# See <https://github.com/rust-lang/rust/issues/127883>
440-
#FIXME: Remove this, and re-enable the same tests in `checktools.sh`, once CI issues are fixed.
441-
- image: x86_64-msvc-ext2
442-
env:
443-
SCRIPT: >
444-
python x.py test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass &&
445-
python x.py test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass &&
446-
python x.py miri --stage 2 library/core --test-args notest &&
447-
python x.py miri --stage 2 library/alloc --test-args notest &&
448-
python x.py miri --stage 2 library/std --test-args notest
449-
450-
HOST_TARGET: x86_64-pc-windows-msvc
451-
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
452-
<<: *job-windows-8c
453-
454-
# Run `checktools.sh` and upload the toolstate file.
455-
- image: x86_64-msvc-ext3
456-
env:
457-
SCRIPT: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
458-
HOST_TARGET: x86_64-pc-windows-msvc
459-
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json
460-
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
461-
<<: *job-windows
462-
463438
# 32/64-bit MinGW builds.
464439
#
465440
# We are using MinGW with POSIX threads since LLVM requires

0 commit comments

Comments
 (0)