Skip to content

Commit 3bc36be

Browse files
Rollup merge of #143379 - jieyouxu:backport-accepted, r=apiraino
Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application The first commit slightly reorganizes `triagebot.toml` (no functional changes) with some dividing sections, because I found it hard to find the actual sections. The second and third commit configures triagebot to post > PR #`{number}` has been **accepted** for **{beta,stable}** backport. to compiler/bootstrap backport threads respectively, when https://github.com/rust-lang/rust/labels/beta-accepted and https://github.com/rust-lang/rust/labels/stable-accepted labels are applied. Best reviewed commit-by-commit. cc `@Kobzol` r? `@apiraino`
2 parents 62a7fb0 + 8ae4fc7 commit 3bc36be

File tree

1 file changed

+90
-19
lines changed

1 file changed

+90
-19
lines changed

triagebot.toml

Lines changed: 90 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
# This file's format is documented at
22
# https://forge.rust-lang.org/triagebot/pr-assignment.html#configuration
33

4+
5+
# ------------------------------------------------------------------------------
6+
# Labels
7+
# ------------------------------------------------------------------------------
8+
49
[relabel]
510
allow-unauthenticated = [
611
"A-*",
@@ -44,6 +49,11 @@ remove_labels = ["S-waiting-on-author"]
4449
# Those labels are added when PR author requests a review from an assignee
4550
add_labels = ["S-waiting-on-review"]
4651

52+
53+
# ------------------------------------------------------------------------------
54+
# Ping groups
55+
# ------------------------------------------------------------------------------
56+
4757
[ping.windows]
4858
message = """\
4959
Hey Windows Group! This bug has been identified as a good "Windows candidate".
@@ -153,6 +163,11 @@ Hi relnotes-interest-group, this issue/PR could use some help in reviewing /
153163
adjusting release notes. Could you take a look if available? Thanks <3
154164
"""
155165

166+
167+
# ------------------------------------------------------------------------------
168+
# Autolabels
169+
# ------------------------------------------------------------------------------
170+
156171
[prioritize]
157172
label = "I-prioritize"
158173

@@ -582,6 +597,11 @@ trigger_files = [
582597
"compiler/rustc_codegen_llvm",
583598
]
584599

600+
601+
# ------------------------------------------------------------------------------
602+
# Prioritization and team nominations
603+
# ------------------------------------------------------------------------------
604+
585605
[notify-zulip."I-prioritize"]
586606
zulip_stream = 245100 # #t-compiler/prioritization/alerts
587607
topic = "#{number} {title}"
@@ -598,6 +618,21 @@ message_on_remove = "Issue #{number}'s prioritization request has been removed."
598618
message_on_close = "Issue #{number} has been closed while requested for prioritization."
599619
message_on_reopen = "Issue #{number} has been reopened."
600620

621+
[notify-zulip."I-types-nominated"]
622+
zulip_stream = 326866 # #T-types/nominated
623+
topic = "#{number}: {title}"
624+
message_on_add = """\
625+
@*T-types* issue #{number} "{title}" has been nominated for team discussion.
626+
"""
627+
message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all for participating!"
628+
message_on_close = "Issue #{number} has been closed. Thanks for participating!"
629+
message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*."
630+
631+
632+
# ------------------------------------------------------------------------------
633+
# Zulip notifications
634+
# ------------------------------------------------------------------------------
635+
601636
[notify-zulip."beta-nominated".rustdoc]
602637
required_labels = ["T-rustdoc"]
603638
zulip_stream = 266220 # #t-rustdoc
@@ -661,15 +696,6 @@ message_on_remove = "PR #{number}'s stable-acceptance has been **removed**."
661696
message_on_close = "PR #{number} has been closed. Thanks for participating!"
662697
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
663698

664-
[notify-zulip."I-types-nominated"]
665-
zulip_stream = 326866 # #T-types/nominated
666-
topic = "#{number}: {title}"
667-
message_on_add = """\
668-
@*T-types* issue #{number} "{title}" has been nominated for team discussion.
669-
"""
670-
message_on_remove = "Issue #{number}'s nomination has been removed. Thanks all for participating!"
671-
message_on_close = "Issue #{number} has been closed. Thanks for participating!"
672-
message_on_reopen = "Issue #{number} has been reopened. Pinging @*T-types*."
673699

674700
[notify-zulip."beta-nominated".compiler]
675701
required_labels = ["T-compiler"]
@@ -688,6 +714,13 @@ don't know
688714
]
689715
message_on_remove = "PR #{number}'s beta-nomination has been removed."
690716

717+
[notify-zulip."beta-accepted".compiler]
718+
required_labels = ["T-compiler"]
719+
zulip_stream = 474880 # #t-compiler/backports
720+
# Put it in the same thread as beta-nominated.
721+
topic = "#{number}: beta-nominated"
722+
message_on_add = "PR #{number} has been **accepted** for **beta** backport."
723+
691724
[notify-zulip."stable-nominated".compiler]
692725
required_labels = ["T-compiler"]
693726
zulip_stream = 474880 # #t-compiler/backports
@@ -706,6 +739,14 @@ don't know
706739
]
707740
message_on_remove = "PR #{number}'s stable-nomination has been removed."
708741

742+
[notify-zulip."stable-accepted".compiler]
743+
required_labels = ["T-compiler"]
744+
zulip_stream = 474880 # #t-compiler/backports
745+
# Put it in the same thread as stable-nominated.
746+
topic = "#{number}: stable-nominated"
747+
message_on_add = "PR #{number} has been **accepted** for **stable** backport."
748+
749+
709750
[notify-zulip."beta-nominated".bootstrap]
710751
required_labels = ["T-bootstrap"]
711752
zulip_stream = 507486 # #t-infra/bootstrap/backports
@@ -723,6 +764,13 @@ don't know
723764
]
724765
message_on_remove = "PR #{number}'s beta-nomination has been removed."
725766

767+
[notify-zulip."beta-accepted".bootstrap]
768+
required_labels = ["T-bootstrap"]
769+
zulip_stream = 507486 # #t-infra/bootstrap/backports
770+
# Put it in the same thread as beta-nominated.
771+
topic = "#{number}: beta-nominated"
772+
message_on_add = "PR #{number} has been **accepted** for **beta** backport."
773+
726774
[notify-zulip."stable-nominated".bootstrap]
727775
required_labels = ["T-bootstrap"]
728776
zulip_stream = 507486 # #t-infra/bootstrap/backports
@@ -741,6 +789,14 @@ don't know
741789
]
742790
message_on_remove = "PR #{number}'s stable-nomination has been removed."
743791

792+
[notify-zulip."stable-accepted".bootstrap]
793+
required_labels = ["T-bootstrap"]
794+
zulip_stream = 507486 # #t-infra/bootstrap/backports
795+
# Put it in the same thread as stable-nominated.
796+
topic = "#{number}: stable-nominated"
797+
message_on_add = "PR #{number} has been **accepted** for **stable** backport."
798+
799+
744800
[notify-zulip."A-edition-2021"]
745801
required_labels = ["C-bug"]
746802
zulip_stream = 268952 # #edition
@@ -757,17 +813,10 @@ message_on_add = """\
757813
Issue #{number} "{title}" has been added.
758814
"""
759815

760-
[no-merges]
761-
exclude_titles = ["Rollup of", "subtree update", "Subtree update"]
762-
labels = ["has-merge-commits", "S-waiting-on-author"]
763-
764-
[github-releases]
765-
format = "rustc"
766-
project-name = "Rust"
767-
changelog-path = "RELEASES.md"
768-
changelog-branch = "master"
769816

770-
[shortcut]
817+
# ------------------------------------------------------------------------------
818+
# Mentions
819+
# ------------------------------------------------------------------------------
771820

772821
[mentions."triagebot.toml"]
773822
message = "`triagebot.toml` has been modified, there may have been changes to the review queue."
@@ -1201,6 +1250,11 @@ cc = ["@m-ou-se"]
12011250
[mentions."compiler/rustc_ast_lowering/src/format.rs"]
12021251
cc = ["@m-ou-se"]
12031252

1253+
1254+
# ------------------------------------------------------------------------------
1255+
# PR assignments
1256+
# ------------------------------------------------------------------------------
1257+
12041258
[assign]
12051259
warn_non_default_branch.enable = true
12061260
contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html"
@@ -1442,6 +1496,23 @@ compiletest = [
14421496

14431497
[pr-tracking]
14441498

1499+
1500+
# ------------------------------------------------------------------------------
1501+
# Misc
1502+
# ------------------------------------------------------------------------------
1503+
1504+
[no-merges]
1505+
exclude_titles = ["Rollup of", "subtree update", "Subtree update"]
1506+
labels = ["has-merge-commits", "S-waiting-on-author"]
1507+
1508+
[github-releases]
1509+
format = "rustc"
1510+
project-name = "Rust"
1511+
changelog-path = "RELEASES.md"
1512+
changelog-branch = "master"
1513+
1514+
[shortcut]
1515+
14451516
# Enable issue transfers within the org
14461517
# Documentation at: https://forge.rust-lang.org/triagebot/transfer.html
14471518
[transfer]

0 commit comments

Comments
 (0)