Skip to content

Commit 2633b85

Browse files
authored
Replace str's transmute() calls with pointer casts
After the following conversation in #rust-lang: ``` [14:43:50] <Ixrec> TIL the implementation of from_utf_unchecked is literally just "mem::transmute(x)" [14:43:59] <Ixrec> no wonder people keep saying transmute is overpowered [15:15:30] <eddyb> Ixrec: it should be a pointer cast lol [15:15:46] <eddyb> unless it doesn't let you [16:50:34] <Ixrec> https://play.rust-lang.org/?gist=d1e6b629ad9ec1baf64ce261c63845e6&version=stable seems like it does let me [16:52:35] <eddyb> Ixrec: yeah that's the preferred impl [16:52:46] <eddyb> Ixrec: it just wasn't in 1.0 [16:52:50] <eddyb> IIRC [16:53:00] <eddyb> (something something fat pointers) ``` Since I already wrote half of the preferred impls in the playground, might as well make an actual PR.
1 parent ef227f5 commit 2633b85

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/libcore/str/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ unsafe fn from_raw_parts_mut<'a>(p: *mut u8, len: usize) -> &'a mut str {
404404
#[inline]
405405
#[stable(feature = "rust1", since = "1.0.0")]
406406
pub unsafe fn from_utf8_unchecked(v: &[u8]) -> &str {
407-
mem::transmute(v)
407+
&*(v as *const [u8] as *const str)
408408
}
409409

410410
/// Converts a slice of bytes to a string slice without checking
@@ -429,7 +429,7 @@ pub unsafe fn from_utf8_unchecked(v: &[u8]) -> &str {
429429
#[inline]
430430
#[stable(feature = "str_mut_extras", since = "1.20.0")]
431431
pub unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str {
432-
mem::transmute(v)
432+
&*(v as *mut [u8] as *mut str)
433433
}
434434

435435
#[stable(feature = "rust1", since = "1.0.0")]
@@ -2447,12 +2447,12 @@ impl StrExt for str {
24472447

24482448
#[inline]
24492449
fn as_bytes(&self) -> &[u8] {
2450-
unsafe { mem::transmute(self) }
2450+
unsafe { &*(self as *const str as *const [u8]) }
24512451
}
24522452

24532453
#[inline]
24542454
unsafe fn as_bytes_mut(&mut self) -> &mut [u8] {
2455-
mem::transmute(self)
2455+
&mut *(self as *mut str as *mut [u8])
24562456
}
24572457

24582458
fn find<'a, P: Pattern<'a>>(&'a self, pat: P) -> Option<usize> {

0 commit comments

Comments
 (0)