Skip to content

Commit 1b8e4b9

Browse files
committed
lint: add comment about diag lints in group
Add a brief comment explaining why the diagnostic migration lints aren't included in the `rustc::internal` diagnostic group. Signed-off-by: David Wood <[email protected]>
1 parent e33cc71 commit 1b8e4b9

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

compiler/rustc_lint/src/lib.rs

+4
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,10 @@ fn register_internals(store: &mut LintStore) {
511511
store.register_late_pass(|| Box::new(Diagnostics));
512512
store.register_lints(&PassByValue::get_lints());
513513
store.register_late_pass(|| Box::new(PassByValue));
514+
// FIXME(davidtwco): deliberately do not include `UNTRANSLATABLE_DIAGNOSTIC` and
515+
// `DIAGNOSTIC_OUTSIDE_OF_IMPL` here because `-Wrustc::internal` is provided to every crate and
516+
// these lints will trigger all of the time - change this once migration to diagnostic structs
517+
// and translation is completed
514518
store.register_group(
515519
false,
516520
"rustc::internal",

0 commit comments

Comments
 (0)