Skip to content

Commit 1a89250

Browse files
authored
Rollup merge of #49439 - GuillaumeGomez:trait-impl-collapse, r=QuietMisdreavus
Fix trait implementation not collapsing docs r? @QuietMisdreavus
2 parents 611ceef + 884153a commit 1a89250

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

src/librustdoc/html/static/main.js

+15-10
Original file line numberDiff line numberDiff line change
@@ -1717,19 +1717,20 @@
17171717
// we are collapsing the impl block
17181718
function implHider(addOrRemove) {
17191719
return function(n) {
1720-
if (hasClass(n, "method")) {
1721-
if (addOrRemove) {
1722-
addClass(n, "hidden-by-impl-hider");
1723-
} else {
1724-
removeClass(n, "hidden-by-impl-hider");
1720+
var is_method = hasClass(n, "method");
1721+
if (is_method || hasClass(n, "type")) {
1722+
if (is_method === true) {
1723+
if (addOrRemove) {
1724+
addClass(n, "hidden-by-impl-hider");
1725+
} else {
1726+
removeClass(n, "hidden-by-impl-hider");
1727+
}
17251728
}
17261729
var ns = n.nextElementSibling;
17271730
while (true) {
17281731
if (ns && (
17291732
hasClass(ns, "docblock") ||
1730-
hasClass(ns, "stability") ||
1731-
false
1732-
)) {
1733+
hasClass(ns, "stability"))) {
17331734
if (addOrRemove) {
17341735
addClass(ns, "hidden-by-impl-hider");
17351736
} else {
@@ -1745,20 +1746,22 @@
17451746
}
17461747

17471748
var relatedDoc = toggle.parentNode;
1749+
var docblock = relatedDoc.nextElementSibling;
17481750

17491751
while (!hasClass(relatedDoc, "impl-items")) {
17501752
relatedDoc = relatedDoc.nextElementSibling;
17511753
}
17521754

1753-
if (!relatedDoc) {
1755+
if (!relatedDoc && !hasClass(docblock, "docblock")) {
17541756
return;
17551757
}
17561758

17571759
// Hide all functions, but not associated types/consts
17581760

17591761
var action = mode;
17601762
if (action === "toggle") {
1761-
if (hasClass(relatedDoc, "fns-now-collapsed")) {
1763+
if (hasClass(relatedDoc, "fns-now-collapsed") ||
1764+
hasClass(docblock, "hidden-by-impl-hider")) {
17621765
action = "show";
17631766
} else {
17641767
action = "hide";
@@ -1767,10 +1770,12 @@
17671770

17681771
if (action === "show") {
17691772
removeClass(relatedDoc, "fns-now-collapsed");
1773+
removeClass(docblock, "hidden-by-usual-hider");
17701774
onEach(toggle.childNodes, adjustToggle(false));
17711775
onEach(relatedDoc.childNodes, implHider(false));
17721776
} else if (action === "hide") {
17731777
addClass(relatedDoc, "fns-now-collapsed");
1778+
addClass(docblock, "hidden-by-usual-hider");
17741779
onEach(toggle.childNodes, adjustToggle(true));
17751780
onEach(relatedDoc.childNodes, implHider(true));
17761781
}

0 commit comments

Comments
 (0)