Skip to content

Commit 0608208

Browse files
committed
Auto merge of #112796 - Kobzol:ci-merge-msvc-cargo-tools, r=pietroalbini
CI: merge msvc cargo and tools jobs The `x86_64-msvc-cargo` and `x86_64-msvc-tools` jobs both run for ~1 hour, but most of that time is actually spent in building LLVM and `rustc`, so I want to try merging them. ![image](https://github.com/rust-lang/rust/assets/4539057/8652fa2a-b8b7-41d0-8f16-555d31acd9a5)
2 parents 85bf079 + e115359 commit 0608208

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

.github/workflows/ci.yml

+3-8
Original file line numberDiff line numberDiff line change
@@ -385,15 +385,10 @@ jobs:
385385
RUST_CONFIGURE_ARGS: "--build=i686-pc-windows-msvc"
386386
SCRIPT: make ci-msvc
387387
os: windows-2019-8core-32gb
388-
- name: x86_64-msvc-cargo
388+
- name: x86_64-msvc-ext
389389
env:
390-
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo
391-
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-lld"
392-
os: windows-2019-8core-32gb
393-
- name: x86_64-msvc-tools
394-
env:
395-
SCRIPT: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
396-
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --save-toolstates=/tmp/toolstate/toolstates.json"
390+
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo && src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
391+
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json"
397392
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
398393
os: windows-2019-8core-32gb
399394
- name: i686-mingw

src/ci/github-actions/ci.yml

+3-9
Original file line numberDiff line numberDiff line change
@@ -590,16 +590,10 @@ jobs:
590590
SCRIPT: make ci-msvc
591591
<<: *job-windows-8c
592592

593-
- name: x86_64-msvc-cargo
593+
- name: x86_64-msvc-ext
594594
env:
595-
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo
596-
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
597-
<<: *job-windows-8c
598-
599-
- name: x86_64-msvc-tools
600-
env:
601-
SCRIPT: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
602-
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --save-toolstates=/tmp/toolstate/toolstates.json
595+
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo && src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh x.py /tmp/toolstate/toolstates.json windows
596+
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld --save-toolstates=/tmp/toolstate/toolstates.json
603597
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
604598
<<: *job-windows-8c
605599

0 commit comments

Comments
 (0)