Skip to content

Commit 038aa0e

Browse files
committed
Allow negative impls just for Send and Sync
1 parent 921ba5a commit 038aa0e

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

src/librustc_typeck/check/wf.rs

+12
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,18 @@ impl<'ccx, 'tcx> CheckTypeWellFormedVisitor<'ccx, 'tcx> {
7676
ast::ItemImpl(_, ast::ImplPolarity::Positive, _, _, _, _) => {
7777
self.check_impl(item);
7878
}
79+
ast::ItemImpl(_, ast::ImplPolarity::Negative, _, Some(ref tref), _, _) => {
80+
let trait_ref = ty::node_id_to_trait_ref(ccx.tcx, tref.ref_id);
81+
match ccx.tcx.lang_items.to_builtin_kind(trait_ref.def_id) {
82+
Some(ty::BoundSend) | Some(ty::BoundSync) => {}
83+
Some(_) | None => {
84+
ccx.tcx.sess.span_err(
85+
item.span,
86+
format!("negative impls are currently \
87+
allowed just for `Send` and `Sync`").as_slice())
88+
}
89+
}
90+
}
7991
ast::ItemFn(..) => {
8092
self.check_item_type(item);
8193
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
#![feature(optin_builtin_traits)]
12+
13+
struct TestType;
14+
15+
trait TestTrait {}
16+
17+
impl !TestTrait for TestType {}
18+
//~^ ERROR negative impls are currently allowed just for `Send` and `Sync`
19+
20+
fn main() {}

0 commit comments

Comments
 (0)