Skip to content
This repository was archived by the owner on Jun 27, 2018. It is now read-only.
This repository was archived by the owner on Jun 27, 2018. It is now read-only.

[Format] inserts output into editor (in some cases) #194

Open
@respeccing

Description

@respeccing

UPDATE: This happens because format depends on rustfmt's returning non-zero exit code when errors happened.

I've tried reverting PR #191 (just to make sure) but the issue remains. So this must've been there from before. I'll see if I can figure out a fix...this is irrelevant

To test, press [Format] on this code:
https://play.rust-lang.org/?gist=31a52c6d6288b16eda5316f014c94a09&version=stable&backtrace=0

before:
fmt0

after:
fmt1

EDIT: To test when it works:
put only this in rust-playpen then press Format:
a backtick character
or
d
(yep, 1 char things)
Now output isn't inserted into editor, because exit code is non-zero in both above cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions