Skip to content
This repository was archived by the owner on Jun 27, 2018. It is now read-only.

[Format] inserts output into editor (in some cases) #194

Open
respeccing opened this issue Apr 3, 2016 · 0 comments
Open

[Format] inserts output into editor (in some cases) #194

respeccing opened this issue Apr 3, 2016 · 0 comments

Comments

@respeccing
Copy link
Contributor

UPDATE: This happens because format depends on rustfmt's returning non-zero exit code when errors happened.

I've tried reverting PR #191 (just to make sure) but the issue remains. So this must've been there from before. I'll see if I can figure out a fix...this is irrelevant

To test, press [Format] on this code:
https://play.rust-lang.org/?gist=31a52c6d6288b16eda5316f014c94a09&version=stable&backtrace=0

before:
fmt0

after:
fmt1

EDIT: To test when it works:
put only this in rust-playpen then press Format:
a backtick character
or
d
(yep, 1 char things)
Now output isn't inserted into editor, because exit code is non-zero in both above cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant