Skip to content

Elision lint should not do anything if trait refs are involved #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manishearth opened this issue Sep 4, 2015 · 1 comment
Closed

Elision lint should not do anything if trait refs are involved #296

Manishearth opened this issue Sep 4, 2015 · 1 comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-middle Type: Probably requires verifiying types

Comments

@Manishearth
Copy link
Member

This is not always elidable, since it's possible to be &'a Trait + 'a too. Neither cases allow elision consistently, AFAICT.

fn foo<'a>(&'a self) -> &'a Trait {

}

walk_tying and searching for anything wrapping a trait except for a Box (TyUniq) should work.
@mcarton mcarton added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-middle Type: Probably requires verifiying types labels Jul 17, 2016
@camsteffen
Copy link
Contributor

Fixed by #452?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages T-middle Type: Probably requires verifiying types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Manishearth @mcarton @camsteffen