Skip to content

clippy 0.0.139 failed to build with the latest nightly (258ae6dd9 2017-06-15) #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kennytm opened this issue Jun 16, 2017 · 1 comment
Closed

Comments

@kennytm
Copy link
Member

kennytm commented Jun 16, 2017

Currently failed due to rust-lang/rust#42648

error[E0463]: can't find crate for `collections`
  --> clippy_lints/src/lib.rs:25:1
   |
25 | extern crate collections;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

(Removing the extern crate should be enough, but I can't get the UI tests to pass.)

diff?
diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs
index c91492c4..b981a4a1 100644
--- a/clippy_lints/src/lib.rs
+++ b/clippy_lints/src/lib.rs
@@ -1,7 +1,6 @@
 // error-pattern:cargo-clippy
 
 #![feature(box_syntax)]
-#![feature(collections)]
 #![feature(custom_attribute)]
 #![feature(i128_type)]
 #![feature(i128)]
@@ -22,7 +21,6 @@ extern crate toml;
 
 // Only for the compile time checking of paths
 extern crate core;
-extern crate collections;
 
 // for unicode nfc normalization
 extern crate unicode_normalization;
diff --git a/clippy_tests/examples/dlist.rs b/clippy_tests/examples/dlist.rs
index b23aeb70..eeeb9c01 100644
--- a/clippy_tests/examples/dlist.rs
+++ b/clippy_tests/examples/dlist.rs
@@ -1,4 +1,4 @@
-#![feature(plugin, collections)]
+#![feature(plugin, alloc)]
 #![feature(associated_type_defaults)]
 #![feature(associated_consts)]
 
@@ -6,8 +6,8 @@
 #![warn(clippy)]
 #![allow(dead_code, needless_pass_by_value)]
 
-extern crate collections;
-use collections::linked_list::LinkedList;
+extern crate alloc;
+use alloc::linked_list::LinkedList;
 
 trait Foo {
     type Baz = LinkedList<u8>;
rustc 1.19.0-nightly (258ae6dd9 2017-06-15)
binary: rustc
commit-hash: 258ae6dd9b1a8ac97986852fc9f00f7687004ccb
commit-date: 2017-06-15
host: x86_64-apple-darwin
release: 1.19.0-nightly
LLVM version: 4.0
@kennytm
Copy link
Member Author

kennytm commented Jun 16, 2017

Looks like already addressed in #1833.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant