Skip to content

Commit e209ff8

Browse files
committed
Fix missing space in the error output
1 parent cf95b86 commit e209ff8

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

clippy_lints/src/methods/iter_overeager_cloned.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ pub(super) fn check<'tcx>(
3636
};
3737
let wildcard_params = map_arg.is_empty().not().then(|| "...").unwrap_or_default();
3838
let msg = format!(
39-
"called `cloned().{}({})` on an `Iterator`. It may be more efficient to call\
40-
`{}({}){}` instead",
39+
"called `cloned().{}({})` on an `Iterator`. It may be more efficient to call `{}({}){}` instead",
4140
name,
4241
wildcard_params,
4342
name,

tests/ui/iter_overeager_cloned.stderr

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,44 @@
1-
error: called `cloned().last()` on an `Iterator`. It may be more efficient to call`.last().cloned()` instead
1+
error: called `cloned().last()` on an `Iterator`. It may be more efficient to call `last().cloned()` instead
22
--> $DIR/iter_overeager_cloned.rs:7:29
33
|
44
LL | let _: Option<String> = vec.iter().cloned().last();
55
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().last().cloned()`
66
|
77
= note: `-D clippy::iter-overeager-cloned` implied by `-D warnings`
88

9-
error: called `cloned().next()` on an `Iterator`. It may be more efficient to call`.next().cloned()` instead
9+
error: called `cloned().next()` on an `Iterator`. It may be more efficient to call `next().cloned()` instead
1010
--> $DIR/iter_overeager_cloned.rs:9:29
1111
|
1212
LL | let _: Option<String> = vec.iter().chain(vec.iter()).cloned().next();
1313
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().chain(vec.iter()).next().cloned()`
1414

15-
error: called `cloned().count()` on an `Iterator`. It may be more efficient to call`.count()` instead
15+
error: called `cloned().count()` on an `Iterator`. It may be more efficient to call `count()` instead
1616
--> $DIR/iter_overeager_cloned.rs:11:20
1717
|
1818
LL | let _: usize = vec.iter().filter(|x| x == &"2").cloned().count();
1919
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().filter(|x| x == &"2").count()`
2020
|
2121
= note: `-D clippy::redundant-clone` implied by `-D warnings`
2222

23-
error: called `cloned().take(...)` on an `Iterator`. It may be more efficient to call`.take(...).cloned()` instead
23+
error: called `cloned().take(...)` on an `Iterator`. It may be more efficient to call `take(...).cloned()` instead
2424
--> $DIR/iter_overeager_cloned.rs:13:21
2525
|
2626
LL | let _: Vec<_> = vec.iter().cloned().take(2).collect();
2727
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().take(2).cloned()`
2828

29-
error: called `cloned().skip(...)` on an `Iterator`. It may be more efficient to call`.skip(...).cloned()` instead
29+
error: called `cloned().skip(...)` on an `Iterator`. It may be more efficient to call `skip(...).cloned()` instead
3030
--> $DIR/iter_overeager_cloned.rs:15:21
3131
|
3232
LL | let _: Vec<_> = vec.iter().cloned().skip(2).collect();
3333
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().skip(2).cloned()`
3434

35-
error: called `cloned().nth(...)` on an `Iterator`. It may be more efficient to call`.nth(...).cloned()` instead
35+
error: called `cloned().nth(...)` on an `Iterator`. It may be more efficient to call `nth(...).cloned()` instead
3636
--> $DIR/iter_overeager_cloned.rs:17:13
3737
|
3838
LL | let _ = vec.iter().filter(|x| x == &"2").cloned().nth(2);
3939
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `vec.iter().filter(|x| x == &"2").nth(2).cloned()`
4040

41-
error: called `cloned().flatten()` on an `Iterator`. It may be more efficient to call`.flatten().cloned()` instead
41+
error: called `cloned().flatten()` on an `Iterator`. It may be more efficient to call `flatten().cloned()` instead
4242
--> $DIR/iter_overeager_cloned.rs:19:13
4343
|
4444
LL | let _ = [Some(Some("str".to_string())), Some(Some("str".to_string()))]

0 commit comments

Comments
 (0)