Cleanup

Author: pmnoxx

clippy_lints/src/methods/iter_overeager_cloned.rs

@@ -19,9 +19,8 @@ pub(super) fn check<'tcx>(
     name: &str,
     map_arg: &[hir::Expr<'_>],
 ) {
-    let recv_ty = cx.typeck_results().expr_ty_adjusted(recv);
     // Check if it's iterator and get type associated with `Item`.
-    let inner_ty = match get_iterator_item_ty(cx, recv_ty) {
+    let inner_ty = match get_iterator_item_ty(cx, cx.typeck_results().expr_ty_adjusted(recv)) {
         Some(ty) => ty,
         _ => return,
     };
@@ -31,7 +30,7 @@ pub(super) fn check<'tcx>(
         _ => return,
     };
 
-    let (lint, preserve_clopned) = match name {
+    let (lint, preserve_cloned) = match name {
         "count" => (REDUNDANT_CLONE, false),
         _ => (ITER_OVEREAGER_CLONED, true),
     };
@@ -43,10 +42,9 @@ pub(super) fn check<'tcx>(
         wildcard_params,
         name,
         wildcard_params,
-        preserve_clopned.then(|| ".cloned()").unwrap_or_default(),
+        preserve_cloned.then(|| ".cloned()").unwrap_or_default(),
     );
 
-    let iter_snippet = snippet(cx, recv.span, "..");
     span_lint_and_sugg(
         cx,
         lint,
@@ -55,10 +53,10 @@ pub(super) fn check<'tcx>(
         "try this",
         format!(
             "{}.{}({}){}",
-            iter_snippet,
+            snippet(cx, recv.span, ".."),
             name,
             map_arg.iter().map(|a| snippet(cx, a.span, "..")).join(", "),
-            preserve_clopned.then(|| ".cloned()").unwrap_or_default(),
+            preserve_cloned.then(|| ".cloned()").unwrap_or_default(),
         ),
         Applicability::MachineApplicable,
     );