Skip to content

Commit d991118

Browse files
committed
Auto merge of #5071 - flip1995:gha, r=<try>
[WIP][DNM] Switch to GitHub Actions cc #4577 This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor. GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). TODO before merge: - [ ] Add `DEPLOY_KEY` secret to github repo - [ ] test deployment on test branch `gh-test` - [ ] talk with `@rust-lang/infra` for bors - [ ] Add back travis + appveyor files for transition period (?) changelog: none
2 parents eff3bc5 + 0c1635d commit d991118

24 files changed

+711
-506
lines changed

.github/deploy.sh

-81
This file was deleted.

.github/deploy_key.enc

-1.64 KB
Binary file not shown.

.github/workflows/clippy.yml

+98
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
name: Clippy Test
2+
3+
on:
4+
push:
5+
# Ignore bors branches, since they are covered by `clippy_bors.yml`
6+
branches-ignore: [auto, try]
7+
# Don't run Clippy tests, when only textfiles were modified
8+
paths-ignore:
9+
- 'COPYRIGHT'
10+
- 'LICENSE-*'
11+
- '**.md'
12+
- '**.txt'
13+
pull_request:
14+
# Don't run Clippy tests, when only textfiles were modified
15+
paths-ignore:
16+
- 'COPYRIGHT'
17+
- 'LICENSE-*'
18+
- '**.md'
19+
- '**.txt'
20+
21+
env:
22+
RUST_BACKTRACE: 1
23+
CARGO_TARGET_DIR: '${{ github.workspace }}/target'
24+
GHA_CI: 1
25+
26+
jobs:
27+
base:
28+
runs-on: ubuntu-latest
29+
30+
steps:
31+
- name: rust-toolchain
32+
uses: actions-rs/[email protected]
33+
with:
34+
toolchain: nightly
35+
target: x86_64-unknown-linux-gnu
36+
profile: minimal
37+
- name: Cache cargo dir
38+
uses: actions/cache@v1
39+
with:
40+
path: ~/.cargo
41+
key: ${{ runner.os }}-x86_64-unknown-linux-gnu
42+
- name: Checkout
43+
uses: actions/[email protected]
44+
- name: Master Toolchain Setup
45+
run: bash setup-toolchain.sh
46+
47+
- name: Set LD_LIBRARY_PATH (Linux)
48+
run: |
49+
SYSROOT=$(rustc --print sysroot)
50+
echo "::set-env name=LD_LIBRARY_PATH::${SYSROOT}/lib${LD_LIBRARY_PATH+:${LD_LIBRARY_PATH}}"
51+
- name: Build
52+
run: cargo build --features deny-warnings
53+
- name: Test
54+
run: cargo test --features deny-warnings
55+
- name: Test clippy_lints
56+
run: cargo test --features deny-warnings
57+
working-directory: clippy_lints
58+
- name: Test rustc_tools_util
59+
run: cargo test --features deny-warnings
60+
working-directory: rustc_tools_util
61+
- name: Test clippy_dev
62+
run: cargo test --features deny-warnings
63+
working-directory: clippy_dev
64+
- name: Test cargo-clippy
65+
run: ../target/debug/cargo-clippy
66+
working-directory: clippy_workspace_tests
67+
- name: Test clippy-driver
68+
run: |
69+
(
70+
set -ex
71+
# Check sysroot handling
72+
sysroot=$(./target/debug/clippy-driver --print sysroot)
73+
test "$sysroot" = "$(rustc --print sysroot)"
74+
75+
desired_sysroot=/tmp
76+
sysroot=$(./target/debug/clippy-driver --sysroot $desired_sysroot --print sysroot)
77+
test "$sysroot" = $desired_sysroot
78+
79+
sysroot=$(SYSROOT=$desired_sysroot ./target/debug/clippy-driver --print sysroot)
80+
test "$sysroot" = $desired_sysroot
81+
82+
# Make sure this isn't set - clippy-driver should cope without it
83+
unset CARGO_MANIFEST_DIR
84+
85+
# Run a lint and make sure it produces the expected output. It's also expected to exit with code 1
86+
# FIXME: How to match the clippy invocation in compile-test.rs?
87+
./target/debug/clippy-driver -Dwarnings -Aunused -Zui-testing --emit metadata --crate-type bin tests/ui/cstring.rs 2> cstring.stderr && exit 1
88+
sed -e 's,tests/ui,$DIR,' -e '/= help/d' cstring.stderr > normalized.stderr
89+
diff normalized.stderr tests/ui/cstring.stderr
90+
91+
# TODO: CLIPPY_CONF_DIR / CARGO_MANIFEST_DIR
92+
)
93+
94+
- name: Run cargo-cache --autoclean
95+
run: |
96+
cargo install cargo-cache --debug
97+
find ~/.cargo/bin ! -type d -exec strip {} \;
98+
cargo cache --autoclean

0 commit comments

Comments
 (0)