Fix pretty fallout

Author: oli-obk

clippy_lints/src/enum_variants.rs

@@ -232,7 +232,7 @@ impl EarlyLintPass for EnumVariantNames {
             if let Some(&(ref mod_name, ref mod_camel)) = self.modules.last() {
                 // constants don't have surrounding modules
                 if !mod_camel.is_empty() {
-                    if mod_name == &item_name {
+                    if *mod_name == item_name {
                         if let ItemKind::Mod(..) = item.node {
                             span_lint(cx,
                                       MODULE_INCEPTION,

clippy_lints/src/needless_pass_by_value.rs

@@ -87,7 +87,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
         let fn_sig = cx.tcx.item_type(fn_def_id).fn_sig();
         let fn_sig = cx.tcx.liberate_late_bound_regions(param_env.free_id_outlive, &fn_sig);
 
-        for ((input, ty), arg) in decl.inputs.iter().zip(fn_sig.inputs()).zip(&body.arguments) {
+        for ((input, &ty), arg) in decl.inputs.iter().zip(fn_sig.inputs()).zip(&body.arguments) {
 
             // Determines whether `ty` implements `Borrow<U>` (U != ty) specifically.
             // This is needed due to the `Borrow<T> for T` blanket impl.
@@ -97,8 +97,8 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
                 } else {
                     None
                 })
-                .filter(|tpred| tpred.def_id() == borrow_trait && &tpred.self_ty() == ty)
-                .any(|tpred| &tpred.input_types().nth(1).expect("Borrow trait must have an parameter") != ty);
+                .filter(|tpred| tpred.def_id() == borrow_trait && tpred.self_ty() == ty)
+                .any(|tpred| tpred.input_types().nth(1).expect("Borrow trait must have an parameter") != ty);
 
             if_let_chain! {[
                 !is_self(arg),

clippy_lints/src/overflow_check_conditional.rs

@@ -38,7 +38,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for OverflowCheckConditional {
             let Expr_::ExprPath(QPath::Resolved(_, ref path1)) = ident1.node,
             let Expr_::ExprPath(QPath::Resolved(_, ref path2)) = ident2.node,
             let Expr_::ExprPath(QPath::Resolved(_, ref path3)) = second.node,
-            &path1.segments[0] == &path3.segments[0] || &path2.segments[0] == &path3.segments[0],
+            path1.segments[0] == path3.segments[0] || path2.segments[0] == path3.segments[0],
             cx.tables.expr_ty(ident1).is_integral(),
             cx.tables.expr_ty(ident2).is_integral()
         ], {
@@ -62,7 +62,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for OverflowCheckConditional {
             let Expr_::ExprPath(QPath::Resolved(_, ref path1)) = ident1.node,
             let Expr_::ExprPath(QPath::Resolved(_, ref path2)) = ident2.node,
             let Expr_::ExprPath(QPath::Resolved(_, ref path3)) = first.node,
-            &path1.segments[0] == &path3.segments[0] || &path2.segments[0] == &path3.segments[0],
+            path1.segments[0] == path3.segments[0] || path2.segments[0] == path3.segments[0],
             cx.tables.expr_ty(ident1).is_integral(),
             cx.tables.expr_ty(ident2).is_integral()
         ], {

clippy_lints/src/utils/mod.rs

@@ -179,7 +179,7 @@ pub fn match_def_path(tcx: ty::TyCtxt, def_id: DefId, path: &[&str]) -> bool {
 
     tcx.push_item_path(&mut apb, def_id);
 
-    apb.names.len() == path.len() && apb.names.iter().zip(path.iter()).all(|(a, &b)| &**a == b)
+    apb.names.len() == path.len() && apb.names.into_iter().zip(path.iter()).all(|(a, &b)| *a == *b)
 }
 
 /// Check if type is struct, enum or union type with given def path.