"Open Cargo.toml" does not do anything in specific scenario

[shoffmeister]

With a specific sequence of steps the "Open Cargo.toml" command of Rust Analyzer can be made to fail:

• Open any Rust project (directory) with a suitable top-level Cargo.toml file
• Close all open text editors
• In vscode Explorer sidebar, single click on the Cargo.toml
  //vscode opens Cargo.toml in a new text editor
• Click on the (x) on the editor tab to close the editor window
  //editor window closes
  // Cargo.toml still highlighted in blue in Explorer Sidebar
• Ctrl+Shift+P for vscode command palette
• "Rust Analyzer: Open Cargo.toml"
  //exp: opens Cargo.toml in editor
  //act: nothing happens

Now, I'd actually suggest that removing the command "Rust Analyzer: Open Cargo.toml" at large is the best way to address this: The ever so handy "Go to file ..." command has auto-completion, so all it takes to get to Cargo.toml is "g f cargo" (or even less depending on completion magic)

Unless "Rust Analyzer: Open Cargo.toml" does more than just "Go to file ... Cargo.toml", I'd propose that it's added value might not be all that great?

[bjorn3]

I believe "Open Cargo.toml" opens the Cargo.toml for the currently open file. If you have a workspace with multiple crates this can be useful to open the right Cargo.toml.

[lnicola]

I guess we could also open the single Cargo.toml file if there was one and report an error otherwise.

[shoffmeister]

I believe "Open Cargo.toml" opens the Cargo.toml for the currently open file. If you have a workspace with multiple crates this can be useful to open the right Cargo.toml.

Ah, that would be an interesting value proposition. But then this command should be named "Open associated Cargo.toml" and ideally not be available for selection in the steps I provided?

Or, if the command cannot be made unavailable, have a modal dialog or a toast saying "No currrent file loaded in editor, cannot open associated Cargo.toml"? Much like when picking the general "Format document" command and there is no formatter installed for ".quokka" files.