You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Skgland opened this issue
Apr 7, 2025
· 2 comments
Labels
A-msrvChange that requires bumping project support MSRVS-blockedStatus: marked as blocked ❌ on something else such as an RFC or other implementation work.
Noting down the PR that removed this will land with 1.87, so it will be a while until we drop support for this.
Veykril
added
S-unactionable
Issue requires feedback, design decisions or is blocked on other work
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
A-msrv
Change that requires bumping project support MSRV
and removed
S-unactionable
Issue requires feedback, design decisions or is blocked on other work
labels
Apr 7, 2025
Once we do remove this, we can remove the rust-intrinsic support with it as well (which needs a 1.86 bump), cc rust-lang/rust#139455
Skgland
changed the title
#[rustc_intrinsic_must_be_overridden] support has been removed from the compiler
"rust-intrinsic" ABI and #[rustc_intrinsic_must_be_overridden] support has been removed from the compiler
Apr 7, 2025
A-msrvChange that requires bumping project support MSRVS-blockedStatus: marked as blocked ❌ on something else such as an RFC or other implementation work.
It came up in rust-lang/rust#132735 that support for
#[rustc_intrinsic_must_be_overridden]
has been removed from rustc but is still present in rust-analyzer.It was suggested rust-lang/rust#132735 (comment) to open an issue here.
Relevant sections of code are
rust-analyzer/crates/hir-expand/src/inert_attr_macro.rs
Lines 643 to 646 in c588273
rust-analyzer/crates/hir-ty/src/mir/eval/shim.rs
Line 85 in c588273
rust-analyzer/crates/intern/src/symbol/symbols.rs
Line 447 in c588273
"rust-intrinsic" support had been removed a bit hastily in rust-lang/rust@51b51b5 which has been reverted in rust-lang/rust#139496
The text was updated successfully, but these errors were encountered: