Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Bring back source compression in base-db #19444

Open
davidbarsky opened this issue Mar 24, 2025 · 3 comments
Open

internal: Bring back source compression in base-db #19444

davidbarsky opened this issue Mar 24, 2025 · 3 comments
Labels
A-perf performance issues

Comments

@davidbarsky
Copy link
Contributor

As part of the new Salsa migration, I dropped source compression in source-db. We should consider bringing that back.

(Original context posted by @lnicola in #19429 (comment))

@ShoyuVanilla ShoyuVanilla added the A-perf performance issues label Mar 25, 2025
@ShoyuVanilla
Copy link
Member

Just out of curiosity, could you explain me the reason it dropped? Maybe the previous compress text setting logic didn't work with new salsa, I guess?

@davidbarsky
Copy link
Contributor Author

I was lazy and didn’t want to think about it when figuring out how to port base-db. I didn’t get around to reintroducing this once I did figure out base-db.

@ShoyuVanilla
Copy link
Member

Thank you for the explanation. The salsa migration was quite a great work and I think that no one would say it was lazy 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-perf performance issues
Projects
None yet
Development

No branches or pull requests

2 participants