Skip to content

Remove decompression support in proc-macro server #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Oct 31, 2024 · 0 comments · Fixed by rust-lang/rust#132402
Closed

Remove decompression support in proc-macro server #18451

Veykril opened this issue Oct 31, 2024 · 0 comments · Fixed by rust-lang/rust#132402
Labels
A-proc-macro proc macro E-easy

Comments

@Veykril
Copy link
Member

Veykril commented Oct 31, 2024 •
edited
Loading

rust-analyzer can probably also remove the support it has in rust-analyzer-proc-macro-server at

rust-analyzer/crates/proc-macro-srv/src/dylib/version.rs

Line 150 in 1aac2c6

Box::new(SnapDecoder::new(snappy_portion))

Originally posted by @bjorn3 in rust-lang/rust#132402 (comment)
@bjorn3 bjorn3 mentioned this issue Oct 31, 2024
Merged
@Veykril Veykril closed this as completed Oct 31, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 1, 2024
@bors
Auto merge of rust-lang#132402 - bjorn3:remove_snap_decompression, r=…
145f9cf 
…jieyouxu,Veykril

Remove support for decompressing dylib metadata

We haven't been compressing dylib metadata for a while now. Removing decompression support will regress error messages about an incompatible rustc version being used, but dylibs are pretty rare anyway.

Fixes rust-lang/rust-analyzer#18451
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Nov 1, 2024
@bors
Auto merge of #132402 - bjorn3:remove_snap_decompression, r=jieyouxu,…
fba37a0 
…Veykril

Remove support for decompressing dylib metadata

We haven't been compressing dylib metadata for a while now. Removing decompression support will regress error messages about an incompatible rustc version being used, but dylibs are pretty rare anyway.

Fixes rust-lang#18451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-proc-macro proc macro E-easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for decompressing dylib metadata bjorn3/rust
1 participant
@Veykril