-
Notifications
You must be signed in to change notification settings - Fork 1.7k
"Locate child modules", inverse of the "Locate parent modules" feature #17401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @Veykril, I would like to work on it! |
Hi I would like to work on this. |
After reading |
what would be the output in the following cases? //- /lib.rs is the ans //- /lib.rs is the ans //- /lib.rs is the ans |
Once you have the |
Yes sounds reasonable
Yes Basically just one level of modules, no more |
Implemented in #19255. |
We currently have a feature that allows running a command to open the parent module(s) of a file's corresponding modules. We should have the inverse of this, opening a popup with the selection of all direct children modules of the currently open file's module(s).
See https://github.com/rust-lang/rust-analyzer/blob/4af21ffb026c7ec3a97a484ca27b36f703eb5fb1/crates/ide/src/parent_module.rs for the parent module implementation, you should be able to trace how this is used to know what to edit to add a similar feature.
This will need an lsp-extension like https://github.com/veykril/rust-analyzer/blob/4af21ffb026c7ec3a97a484ca27b36f703eb5fb1/crates/rust-analyzer/src/lsp/ext.rs#L389-L395 and vscode glue like
rust-analyzer/editors/code/src/lsp_ext.ts
Lines 188 to 192 in 4af21ff
The text was updated successfully, but these errors were encountered: