Skip to content

Macro metavar length got renamed to len #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue May 16, 2024 · 5 comments
Closed

Macro metavar length got renamed to len #17242

Veykril opened this issue May 16, 2024 · 5 comments
Assignees
@randomicon00
Labels
A-macro macro expansion E-easy E-has-instructions Issue has some instructions and pointers to code to get started

Comments

@Veykril
Copy link
Member

Veykril commented May 16, 2024

See rust-lang/rust#124987, we need to do the same
@Veykril Veykril added E-easy A-macro macro expansion labels May 16, 2024
@lnicola
Copy link
Member

lnicola commented May 18, 2024

I guess this is

rust-analyzer/crates/mbe/src/parser.rs

Line 348 in 6524922

"length" => Op::Length { depth: parse_depth(&mut args)? },
, but should we wait until 1.80 is released?

@lnicola lnicola added the E-has-instructions Issue has some instructions and pointers to code to get started label May 18, 2024
@Veykril
Copy link
Member Author

Veykril commented May 18, 2024

Well, it is still unstable and fortunately the standard library doesn't use this one so I don't think there is any value in waiting on it? (though we could temporarily support both)

@randomicon00
Copy link
Contributor

randomicon00 commented May 18, 2024 •
edited
Loading

Hi @Veykril & @lnicola, Currently, I have more free time to contribute to rust-analyzer. I would like to work on it!

@Veykril
Copy link
Member Author

Veykril commented May 19, 2024

Go ahead!

@randomicon00 randomicon00 mentioned this issue Jun 11, 2024
Merged
bors added a commit that referenced this issue Jun 11, 2024
@bors
Auto merge of #17392 - randomicon00:17242, r=Veykril
0a16ae3 
Change 'Length' to 'Len'

This is a fix for #17242
@lnicola
Copy link
Member

lnicola commented Jun 11, 2024

Fixed in #17242.

@lnicola lnicola closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@randomicon00 randomicon00

Labels
A-macro macro expansion E-easy E-has-instructions Issue has some instructions and pointers to code to get started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lnicola @Veykril @randomicon00