add completions for clippy lint in attributes

Signed-off-by: Benjamin Coenen <[email protected]>

Author: bnjjj

crates/ide/src/completion/generated_lint_completions.rs

@@ -1,9 +1,5 @@
 //! Generates descriptors structure for unstable feature from Unstable Book
-use std::{
-    fs::File,
-    io::Read,
-    path::{Path, PathBuf},
-};
+use std::path::{Path, PathBuf};
 
 use quote::quote;
 use walkdir::WalkDir;
@@ -22,7 +18,7 @@ pub fn generate_lint_completions(mode: Mode) -> Result<()> {
     let ts_features = generate_descriptor("./target/rust/src/doc/unstable-book/src".into())?;
     run!("curl http://rust-lang.github.io/rust-clippy/master/lints.json --output ./target/clippy_lints.json")?;
 
-    let ts_clippy = generate_descriptor_clippy("./target/clippy_lints.json")?;
+    let ts_clippy = generate_descriptor_clippy(&Path::new("./target/clippy_lints.json"))?;
     let ts = quote! {
         use crate::completion::complete_attribute::LintCompletion;
         #ts_features
@@ -70,10 +66,8 @@ struct ClippyLint {
     id: String,
 }
 
-fn generate_descriptor_clippy(uri: &str) -> Result<proc_macro2::TokenStream> {
-    let mut file = File::open(uri)?;
-    let mut file_content = String::new();
-    file.read_to_string(&mut file_content)?;
+fn generate_descriptor_clippy(path: &Path) -> Result<proc_macro2::TokenStream> {
+    let file_content = fs2::read_to_string(path)?;
     let mut clippy_lints: Vec<ClippyLint> = vec![];
 
     for line in file_content.lines().map(|line| line.trim()) {
@@ -89,10 +83,14 @@ fn generate_descriptor_clippy(uri: &str) -> Result<proc_macro2::TokenStream> {
             };
             clippy_lints.push(clippy_lint)
         } else if line.starts_with(r#""What it does":"#) {
+            // Typical line to strip: "What is doest": "Here is my useful content",
+            let prefix_to_strip = r#""What it does": ""#;
+            let suffix_to_strip = r#"","#;
+
             clippy_lints.last_mut().expect("clippy lint must already exist").help = line
-                .strip_prefix(r#""What it does": ""#)
+                .strip_prefix(prefix_to_strip)
                 .expect("should be prefixed by what it does")
-                .strip_suffix(r#"","#)
+                .strip_suffix(suffix_to_strip)
                 .expect("should be suffixed by comma")
                 .into();
         }

xtask/src/codegen/gen_lint_completions.rs

@@ -152,11 +152,11 @@ See https://github.com/rust-lang/rust-clippy/issues/5537 for discussion.
 
 #[test]
 fn check_licenses() {
-    let mut expected = "
+    let expected = "
 0BSD OR MIT OR Apache-2.0
 Apache-2.0
-Apache-2.0 OR MIT
 Apache-2.0 OR BSL-1.0
+Apache-2.0 OR MIT
 Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT
 Apache-2.0/MIT
 BSD-2-Clause
@@ -185,7 +185,6 @@ Zlib OR Apache-2.0 OR MIT
         .collect::<Vec<_>>();
     licenses.sort();
     licenses.dedup();
-    expected.sort();
     assert_eq!(licenses, expected);
 }