adding doc and simplifying function

Author: bruno-ortiz

crates/rust-analyzer/src/handlers.rs

@@ -134,19 +134,18 @@ pub(crate) fn fetch_dependency_list(
     _params: lsp_ext::FetchDependencyListParams,
 ) -> Result<lsp_ext::FetchDependencyListResult> {
     let crates = state.analysis.fetch_crates()?;
-    Ok(FetchDependencyListResult {
-        crates: crates
-            .into_iter()
-            .filter_map(|it| {
-                let root_file_path = state.file_id_to_file_path(it.root_file_id);
-                crate_path(it.name.as_ref(), root_file_path).map(|crate_path| CrateInfoResult {
-                    name: it.name,
-                    version: it.version,
-                    path: crate_path.to_string(),
-                })
+    let crate_infos = crates
+        .into_iter()
+        .filter_map(|it| {
+            let root_file_path = state.file_id_to_file_path(it.root_file_id);
+            crate_path(it.name.as_ref(), root_file_path).map(|path| CrateInfoResult {
+                name: it.name,
+                version: it.version,
+                path: path.to_string(),
             })
-            .collect(),
-    })
+        })
+        .collect();
+    Ok(FetchDependencyListResult { crates: crate_infos })
 }
 
 pub(crate) fn handle_shuffle_crate_graph(state: &mut GlobalState, _: ()) -> Result<()> {
@@ -1190,7 +1189,7 @@ pub(crate) fn handle_code_action_resolve(
                 "Failed to parse action id string '{}': {e}",
                 params.id
             ))
-            .into())
+            .into());
         }
     };
 
@@ -1210,14 +1209,14 @@ pub(crate) fn handle_code_action_resolve(
             "Failed to find the assist for index {} provided by the resolve request. Resolve request assist id: {}",
             assist_index, params.id,
         ))
-        .into())
+            .into())
     };
     if assist.id.0 != expected_assist_id || assist.id.1 != expected_kind {
         return Err(invalid_params_error(format!(
             "Mismatching assist at index {} for the resolve parameters given. Resolve request assist id: {}, actual id: {:?}.",
             assist_index, params.id, assist.id
         ))
-        .into());
+            .into());
     }
     let ca = to_proto::code_action(&snap, assist.clone(), None)?;
     code_action.edit = ca.edit;
@@ -1287,7 +1286,7 @@ pub(crate) fn handle_code_lens_resolve(
     snap: GlobalStateSnapshot,
     code_lens: CodeLens,
 ) -> Result<CodeLens> {
-    let Some(annotation) = from_proto::annotation(&snap, code_lens.clone())? else { return Ok(code_lens) };
+    let Some(annotation) = from_proto::annotation(&snap, code_lens.clone())? else { return Ok(code_lens); };
     let annotation = snap.analysis.resolve_annotation(annotation)?;
 
     let mut acc = Vec::new();
@@ -1934,23 +1933,33 @@ fn run_rustfmt(
     }
 }
 
-//Thats a best effort to try and find the crate path
+/// Searches for the directory of a Rust crate with a given name in the directory tree
+/// of the root file of that crate.
+///
+/// # Arguments
+///
+/// * `crate_name`: The name of the crate to search for. This should be a `Some` value if
+///   a crate name has been specified, or `None` if no crate name has been specified.
+/// * `root_file_path`: The path to the root file of the crate.
+///
+/// # Returns
+///
+/// An `Option` value representing the path to the directory of the crate with the given
+/// name, if such a crate is found. If no crate with the given name is found, this function
+/// returns `None`.
 fn crate_path(crate_name: Option<&String>, root_file_path: VfsPath) -> Option<VfsPath> {
     crate_name.and_then(|crate_name| {
-        let mut crate_path = None;
         let mut root_path = root_file_path;
         while let Some(path) = root_path.parent() {
-            match path.name_and_extension() {
-                Some((name, _)) => {
-                    if name.starts_with(crate_name.as_str()) {
-                        crate_path = Some(path);
-                        break;
-                    }
+            if let Some((name, _)) = path.name_and_extension() {
+                if name.starts_with(crate_name.as_str()) {
+                    return Some(path);
                 }
-                None => break,
+            } else {
+                break;
             }
             root_path = path;
         }
-        crate_path
+        None
     })
 }