Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Workspace tests #455

Closed
nrc opened this issue Aug 22, 2017 · 2 comments
Closed

Workspace tests #455

nrc opened this issue Aug 22, 2017 · 2 comments
Assignees
@Xanewok
Labels
testing
Milestone
impl period

Comments

@nrc
Copy link
Member

nrc commented Aug 22, 2017

These don't work when we're in the Rust CI because of nested workspaces. I've removed them for now, but we should find a way to re-enable them.

cc @Xanewok @alexcrichton
nrc added a commit that referenced this issue Aug 22, 2017
@nrc
Remove simple_workspace test
bf8f77e 
Should be temporary

cc #455
@nrc
Copy link
Member Author

nrc commented Aug 22, 2017

To recover the test, revert bf8f77e

@Xanewok Xanewok mentioned this issue Aug 25, 2017
Merged
@nrc nrc added the testing label Sep 14, 2017
@nrc nrc added this to the impl period milestone Sep 14, 2017
@Xanewok Xanewok self-assigned this Oct 30, 2017
@bvinc bvinc mentioned this issue Dec 1, 2017
Merged
@Xanewok
Copy link
Member

Xanewok commented Jan 12, 2018

Talked to @matklad some time ago and the approach of generating test cases that are Rust project themselves works for Cargo in Rust CI environment, since the test data is generated in the output target/ directory, which is not considered as code (hence side-stepping the issue of workspace test cases that block Rust CI).
Similar harness was implemented in #607 by @bvinc with workspace tests restored, so this is not an issue anymore.

@Xanewok Xanewok closed this as completed Jan 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Xanewok Xanewok

Labels
testing
Projects
None yet
Milestone
impl period
Development

No branches or pull requests
2 participants
@nrc @Xanewok