Make build_lib, build_bin, and cfg_test unstable

And change the default of all_targets to true

Author: nrc

README.md

@@ -93,14 +93,6 @@ project.
 
 Currently we accept the following options:
 
-* `build_lib` (`bool`, defaults to `false`) checks the project as if you passed
-  the `--lib` argument to cargo. Mutually exclusive with, and preferred over,
-  `build_bin`.
-* `build_bin` (`String`, defaults to `""`) checks the project as if you passed
-  `-- bin <build_bin>` argument to cargo. Mutually exclusive with `build_lib`.
-* `cfg_test` (`bool`, defaults to `false`) checks the project as if you were
-  running `cargo test` rather than `cargo build`. I.e., compiles (but does not
-  run) test code.
 * `unstable_features` (`bool`, defaults to `false`) enables unstable features.
   Currently no option requires this flag.
 * `sysroot` (`String`, defaults to `""`) if the given string is not empty, use
@@ -110,7 +102,7 @@ Currently we accept the following options:
   the given target triple for all rustc invocations
 * `wait_to_build` (`u64`, defaults to `1500`) time in milliseconds between
   receiving a change notification and starting build
-* `all_targets` (`bool`, defaults to `false`) checks the project as if you were
+* `all_targets` (`bool`, defaults to `true`) checks the project as if you were
   running `cargo check --all-targets`. I.e., check all targets and integration
   tests too
 * `use_crate_blacklist` (`bool`, defaults to `true`) if disabled, also indexes
@@ -129,6 +121,18 @@ Currently we accept the following options:
   - `"opt-in"` Clippy lints are shown when crates specify `#![warn(clippy)]`.
   - `"on"` Clippy lints enabled for all crates in workspace.
 
+and the following unstable options:
+
+* `build_lib` (`bool`, defaults to `false`) checks the project as if you passed
+  the `--lib` argument to cargo. Mutually exclusive with, and preferred over,
+  `build_bin`.
+* `build_bin` (`String`, defaults to `""`) checks the project as if you passed
+  `-- bin <build_bin>` argument to cargo. Mutually exclusive with `build_lib`.
+* `cfg_test` (`bool`, defaults to `false`) checks the project as if you were
+  running `cargo test` rather than `cargo build`. I.e., compiles (but does not
+  run) test code.
+
+
 ## Troubleshooting
 
 For tips on debugging and troubleshooting, see [debugging.md](debugging.md).

src/config.rs

@@ -170,7 +170,7 @@ impl Default for Config {
             all_features: false,
             no_default_features: false,
             jobs: None,
-            all_targets: false,
+            all_targets: true,
             racer_completion: true,
             clippy_preference: ClippyPreference::OptIn,
         };
@@ -182,6 +182,7 @@ impl Default for Config {
 impl Config {
     /// Join this configuration with the new config.
     pub fn update(&mut self, mut new: Config) {
+        new.normalise();
         new.target_dir = self.target_dir.combine_with_default(&new.target_dir, None);
         new.build_lib = self.build_lib.combine_with_default(&new.build_lib, false);
         new.build_bin = self.build_bin.combine_with_default(&new.build_bin, None);
@@ -208,6 +209,9 @@ impl Config {
 
         if !self.unstable_features {
             // Force-set any unstable features here.
+            self.build_bin = Inferrable::Inferred(None);
+            self.build_lib = Inferrable::Inferred(false);
+            self.cfg_test = false;
         }
     }