changes after code review

Author: algesten

src/actions/post_build.rs

@@ -89,8 +89,7 @@ impl PostBuildHandler {
                     // It's not a good idea to make a long message here, the output in
                     // VSCode is one single line, and it's important to capture the
                     // root cause.
-                    // let msg = format!("There was an error trying to build, RLS features will be limited: {}", cause);
-                    self.notifier.notify_build_error_diagnostics(cause);
+                    self.notifier.notify_error_diagnostics(cause);
                 }
                 self.notifier.notify_end_diagnostics();
                 self.active_build_count.fetch_sub(1, Ordering::SeqCst);

src/actions/progress.rs

@@ -34,7 +34,7 @@ pub enum ProgressUpdate {
 pub trait DiagnosticsNotifier: Send {
     fn notify_begin_diagnostics(&self);
     fn notify_publish_diagnostics(&self, PublishDiagnosticsParams);
-    fn notify_build_error_diagnostics(&self, msg: String);
+    fn notify_error_diagnostics(&self, msg: String);
     fn notify_end_diagnostics(&self);
 }
 
@@ -121,7 +121,7 @@ impl<O: Output> DiagnosticsNotifier for BuildDiagnosticsNotifier<O> {
     fn notify_publish_diagnostics(&self, params: PublishDiagnosticsParams) {
         self.out.notify(Notification::<PublishDiagnostics>::new(params));
     }
-    fn notify_build_error_diagnostics(&self, message: String) {
+    fn notify_error_diagnostics(&self, message: String) {
         self.out.notify(Notification::<ShowMessage>::new(ShowMessageParams {
              typ: MessageType::Error,
              message: message.to_owned(),

src/build/cargo.rs

@@ -94,7 +94,7 @@ pub(super) fn cargo(internals: &Internals, package_arg: PackageArg, progress_sen
                 format!("({})", stdout)
             };
             let msg = format!("Cargo failed: {}{}", err, stdout_msg);
-            info!("{}", msg);
+            debug!("{}", msg);
             BuildResult::Err(msg, None)
         }
     }